Make the Monaco editor Fields support preview #10777
Conversation
|
Why not on each key stroke like the other editors? |
|
I don't know much about Monaco, but I see that this code is only going to trigger the get value action when the submit is clicked, so I think this is a performance optimization. Of course I could also add custom switch options for the Monaco editor, for example, the default is to trigger the update by each key, and Ctrl+S only after the switch is turned on , I think this would be a better solution. |
|
Noone will ever know to enable it with Ctrl+S Can you try with just keystrokes and if the performance is fine, I think that will be ok |
|
If there are still any performance issues, adding a throttle on keystrokes might solve them. |
change previewButton use named window
|
updated , and change the preview fonction, use a named window to avoid always open new window
|
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| @if (hasPreviewPermission) | |||
| { | |||
| <a id="previewButton" target="_blank" class="btn btn-info" href="@Url.Action("Index", "Preview", new { area = "OrchardCore.ContentPreview", id = previewId })">@T["Preview"]</a> | |||
| <a id="previewButton" target="previewWindow" class="btn btn-info" href="@Url.Action("Index", "Preview", new { area = "OrchardCore.ContentPreview", id = previewId })">@T["Preview"]</a> | |||
There was a problem hiding this comment.
@Skrypt do you agree with this change? I think I do (but equally if I have multiple Orchard instances running (dev and live), it will confuse me when it keeps swapping windows around on me?
Other changes look good to me.
There was a problem hiding this comment.
I'm not sure, to be honest. Could we not have a unique identifier for this target instead?
There was a problem hiding this comment.
add the host name as perfix?
There was a problem hiding this comment.
I would prefer removing it, and opending a seperate issue so we can have a proper review of it.
There was a problem hiding this comment.
@deanmarcussen , target="previewWindow" removed
| @@ -46,7 +46,7 @@ | |||
|
|
|||
| var editor = monaco.editor.create(document.getElementById('@Html.IdFor(x => x.Html)_editor'), settings); | |||
| var textArea = document.getElementById('@Html.IdFor(x => x.Html)'); | |||
|
|
|||
| editor.getModel().onDidChangeContent((event) => { | |||
There was a problem hiding this comment.
How come I see the exact same code that you're adding up on L50?
i.e. don't we already do this?
//for preview
if(document.getElementById("previewButton")){
editor.getModel().onDidChangeContent((event) => {
textArea.value = editor.getValue();
$(document).trigger('contentpreview:render');
});
}
There was a problem hiding this comment.
Yes , you are right ..
I didn't notice the codes 。
| @@ -49,6 +49,13 @@ | |||
| window.addEventListener("submit", function () { | |||
| textArea.value = editor.getValue(); | |||
| }); | |||
| //for preview | |||
| if(document.getElementById("previewButton")){ | |||
There was a problem hiding this comment.
Don't think we need this check, we don't use it anywhere else.
Can you remove for consistency?
Thanks
| textArea.value = editor.getValue(); | ||
| $(document).trigger('contentpreview:render'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Remove the extra line, you could add it before line 52
There was a problem hiding this comment.
I agree. Please format the code appropriately.
Modify HtmlField and TextField to use Ctrl-S to trigger previews when using the Monaco editor