Remove exists check for blobs #10960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch BlobFileStore.GetFileInfoAsync to handle blob not found exceptions as opposed to doing an explicit ExistsAsync() check. This call is quite expensive when considering that callers to GetFileInfoAsync are normally going to find the blob due to the app being very read heavy.
sebastienros
reviewed
Jan 8, 2022
| var properties = await blob.GetPropertiesAsync(); | ||
|
|
||
| return new BlobFile(path, properties.Value.ContentLength, properties.Value.LastModified); | ||
| } | ||
| catch (RequestFailedException ex) when (ex.ErrorCode == "BlobNotFound") // Instead of ExistsAsync() check which is 'slow' if we're expecting to find the blob |
There was a problem hiding this comment.
Does it work with this property instead of a string: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Blobs/src/Generated/Models/BlobErrorCode.cs#L230
There was a problem hiding this comment.
Yes, tested it out and using the BlobErrorCode works.
Switch to using constant for error code
…ourtrille/OrchardCore into removeExistsCheckForBlobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10876 I have found a good performance improvement in the BlobFileStore by replacing the ExistsAsync call with a handler for the exception which occurs if the blob doesn't exist.