Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to packages #11053

Merged
merged 5 commits into from
Jan 27, 2022
Merged

Conversation

ns8482e
Copy link
Contributor

@ns8482e ns8482e commented Jan 22, 2022

Adding orchard core logo to nuget package

Fixes #11050

image

@Skrypt
Copy link
Contributor

Skrypt commented Jan 22, 2022

Just make sure it is the appropriate logo file.

@ns8482e ns8482e requested a review from agriffard as a code owner January 22, 2022 16:57
@ns8482e
Copy link
Contributor Author

ns8482e commented Jan 22, 2022

@Skrypt

Just make sure it is the appropriate logo file.

Updated

@Skrypt
Copy link
Contributor

Skrypt commented Jan 22, 2022

The size and png transparency makes more sense. Thanks @ns8482e

@Skrypt
Copy link
Contributor

Skrypt commented Jan 26, 2022

@Piedone I think you need to approve again. There is some bug.

@Skrypt Skrypt closed this Jan 26, 2022
@Skrypt Skrypt reopened this Jan 26, 2022
@Skrypt Skrypt requested a review from Piedone January 26, 2022 18:59
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienros sebastienros merged commit 51cfd52 into OrchardCMS:main Jan 27, 2022
@ns8482e ns8482e deleted the ns8482e/#nuget-logo branch January 28, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orchard logo as icon for each NuGet package
5 participants