Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Form : Allow to override Index used #11165

Merged
merged 3 commits into from
Feb 13, 2022
Merged

Search Form : Allow to override Index used #11165

merged 3 commits into from
Feb 13, 2022

Conversation

Skrypt
Copy link
Contributor

@Skrypt Skrypt commented Feb 11, 2022

Fixes #11164

Allows passing a QueryString param in the search form page to override the current default Index used for displaying results. This can also be set as a hidden form input fixed value if used from a different form. These Indices are protected by permissions so it should be fine to allow to do this instead of needing to create a different controller per index required to be searched from.

Usage : /search?Terms=moon&Index=BlogIndex

@saleemhaq
Copy link

Guys who have write access so please merege that work: Pull Request here : #11165 please.

@hishamco
Copy link
Member

@saleemhaq please don't push the team, all the OC dev have permission, but every PR should be validated from different anglee, some may take hours and some may takes months to get them merge

I advice you fork the repo and apply these changes if you are in urgent case, otherwise be patient until the reviewer approve this

@Skrypt Skrypt merged commit 1d4f283 into main Feb 13, 2022
@Skrypt Skrypt deleted the skrypt/#11164 branch February 13, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Form : Allow to override Index used by using a QueryString/Form param
4 participants