Add UI for email proxy settings #11274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
|
|
We could add a toggle checkbox to display proxy settings, but I find it's useful to put them underneath the server host / port |
sebastienros
reviewed
Mar 8, 2022
| <div id="@Html.Id("SelectEncryptionMethod")" class="form-group" asp-validation-class-for="EncryptionMethod"> | ||
| <label asp-for="EncryptionMethod">@T["Encryption method to use"]</label> | ||
| <select asp-for="EncryptionMethod" class="form-control" disabled="@Model.AutoSelectEncryption"> | ||
| <option value="@SmtpEncryptionMethod.None" selected="@(SmtpEncryptionMethod.None == Model.EncryptionMethod ? true : false)"> |
There was a problem hiding this comment.
I think razor is clever enough to just use selected="@(SmtpEncryptionMethod.None == Model.EncryptionMethod)"
There was a problem hiding this comment.
Saw that it was not part of the PR
There was a problem hiding this comment.
You Right, seems we need to change in many places
There was a problem hiding this comment.
Seb can we merge this, then I can look for the places that may need to change
|
Crowdin Translations updated to include those added by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.