Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for using Orchard Core from a local NuGet packages #11284

Merged
merged 4 commits into from
Mar 5, 2022
Merged

Added documentation for using Orchard Core from a local NuGet packages #11284

merged 4 commits into from
Mar 5, 2022

Conversation

DrewBrasher
Copy link
Contributor

Adding this documentation was suggested in this discussion: #10588 (reply in thread)

@DrewBrasher DrewBrasher requested a review from agriffard as a code owner March 1, 2022 12:43
<packageSources>
<clear />
<add key="NuGet" value="https://api.nuget.org/v3/index.json" />
<add key="MyFeed" value="\\{YourServer}\NuGetServer" />
Copy link
Contributor

@Skrypt Skrypt Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        <add key="MyFeed" value="\\{YourServer}\NuGetServer" />
        <add key="NuGet" value="https://api.nuget.org/v3/index.json" />

The local feed should be set before the Nuget (Public) one so that it knows which one to retrieve from first (priority).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 34d5ddf

@ns8482e
Copy link
Contributor

ns8482e commented Mar 2, 2022

This guide is optional for advance users and Adding this to getting started doesn’t seems to be the right place, as it’s confusing to new users

@Skrypt
Copy link
Contributor

Skrypt commented Mar 2, 2022

Move it to "How to guides". Else, we could add it to the repository Wiki.

@DrewBrasher
Copy link
Contributor Author

What order should it go in the How to Guides left menu and should it also be listed in the Follow the Guides page?

@DrewBrasher
Copy link
Contributor Author

Also, is there a better menu title than "Using local package source"?

@Skrypt
Copy link
Contributor

Skrypt commented Mar 2, 2022

Ok I changed my mind. Move this to "Key Topics" as "Using local NuGet packages" under "Using Docker".

@hishamco
Copy link
Member

hishamco commented Mar 2, 2022

Why under Using Docker?

@agriffard agriffard merged commit a8ef019 into OrchardCMS:main Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants