Fix Content Drivers #15680
Fix Content Drivers #15680
Conversation
| Shape("ContentsTags_SummaryAdmin", contentItemViewModel).Location("SummaryAdmin", "Tags:10"), | ||
| Shape("ContentsMeta_SummaryAdmin", contentItemViewModel).Location("SummaryAdmin", "Meta:20"), | ||
| Shape("ContentsTags_SummaryAdmin", new ContentItemViewModel(contentItem)).Location("SummaryAdmin", "Tags:10"), | ||
| Shape("ContentsMeta_SummaryAdmin", new ContentItemViewModel(contentItem)).Location("SummaryAdmin", "Meta:20"), |
There was a problem hiding this comment.
Why you need to new up ContentItemViewModel in each call?!!
There was a problem hiding this comment.
I am not positive on this response. But, I believe because the VM here is a shape but rendered using a different type. For it to work correctly, each shape should be a new instance as it'll have to be built and rendered separately.
The PR #15652 caused the issue which created a single VM instead of having multiple
There was a problem hiding this comment.
Yeah. It's worth trying to pass a model instead of a shape to all these views. In other words, do not let ContentItemViewModel inherit from ShapeViewModel, create a single instance and pass it to all these views. This may work, but could break someone. Anyway, if it works it should reduce allocations. Feel free to try it. Otherwise, I may try it when I have time. Meanwhile this PR fixes the referenced problem while we can entertain other ways to improve.
Fix #15674