Skip to content

Conversation

naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Sep 5, 2025

Changes

  • Fixed verificationEpoch calc to use the slot of the parent root in verifyBalances

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

github-actions bot commented Sep 5, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 6dacbe0

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.73%. Comparing base (9c7bfac) to head (6dacbe0).
⚠️ Report is 2 commits behind head on nicka/pectra.

Additional details and impacted files
@@               Coverage Diff                @@
##           nicka/pectra    #2656      +/-   ##
================================================
- Coverage         42.40%   41.73%   -0.67%     
================================================
  Files               122      122              
  Lines              5707     5707              
  Branches           1517     1517              
================================================
- Hits               2420     2382      -38     
- Misses             3284     3322      +38     
  Partials              3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@naddison36 naddison36 changed the title Fixed verificationEpoch calc to use the slot of the parent root SP-09 Fixed verificationEpoch calc to use the slot of the parent root Sep 5, 2025
@naddison36 naddison36 merged commit 70f9171 into nicka/pectra Sep 5, 2025
17 of 21 checks passed
@naddison36 naddison36 deleted the nicka/pectra-verification-epoch branch September 5, 2025 07:01
@naddison36 naddison36 changed the title SP-09 Fixed verificationEpoch calc to use the slot of the parent root ORGN-09 Fixed verificationEpoch calc to use the slot of the parent root Sep 5, 2025
@sparrowDom
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants