-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement drag and drop mechanic for a card #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriginalUtkin
commented
Dec 31, 2020
OriginalUtkin
commented
Dec 31, 2020
certator
reviewed
Jan 2, 2021
certator
approved these changes
Jan 2, 2021
This was referenced Jan 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that MR I'd like to introduce drag and drop mechanic for manipulating with cards.
Before: Previously we had all callbacks are defined in the
Main.cs
and manipulating (set and call) via delegates. That lead to a lot of dependencies that are sent through the code and required to pass additional parameters during the initialisation + define it in the places (seeMain.cs
where it doesn't suit logically).Now: Since
SimpleCard
card script is responsible for card visualisation (contains face prefab, card position on scene, etc.) we could say that it is the perfect place to define how card GUI representation should interact with mouse cursor. Since GUI is responsible for manipulating with an object, we also need to define how this object will be handed by others when mouse button will be up and card will be dropped to other object. For that purpose I've implemented theIInteractable
interface that define method for receiving any type of object that is inherited fromMonoBehavior
. For now, onlyPlayerBattlefield
implements this interface. The main point is that each object that could communicate with an another should implement this interface. In that case, caller side won't know any implementation details but only that object under selected one is able to handle it.