Fix default complexity issue and upgraded critical dependency #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
us1415
reviewed
Apr 8, 2025
us1415
reviewed
Apr 8, 2025
us1415
approved these changes
Apr 8, 2025
Collaborator
us1415
left a comment
us1415
left a comment
There was a problem hiding this comment.
I had a couple of questions which were answered. Thank you @bhaumikmaan
Ornithopter-pilot
approved these changes
Apr 8, 2025
Collaborator
Ornithopter-pilot
left a comment
Ornithopter-pilot
left a comment
There was a problem hiding this comment.
LGTM! This PR successfully addresses the time and space complexity calculation issues while also upgrading the Vite dependency to fix a security vulnerability. The complexity formatting improvements are particularly valuable as they now handle edge cases more gracefully and don't default to assuming O(n) complexity. The changes are focused and don't introduce any regressions. Approving this PR.
Collaborator
|
@bhaumikmaan , looks good to me .. u can go ahead |
Collaborator
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
O(N)which is incorrectFIXES
npm i