v2: Update to new observable placeholder specification #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #393 +/- ##
===========================================
- Coverage 74.00% 73.97% -0.04%
===========================================
Files 58 58
Lines 6470 6489 +19
Branches 1115 1120 +5
===========================================
+ Hits 4788 4800 +12
- Misses 1260 1264 +4
- Partials 422 425 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dilpath
approved these changes
Jul 1, 2025
petab/v2/petab1to2.py
Outdated
Comment on lines
412
to
422
| # the current sorting will fail for 10+ placeholders, but who does | ||
| # that anyway? | ||
| return v2.C.PARAMETER_SEPARATOR.join( | ||
| sorted( | ||
| str(sym) | ||
| for sym in expr.free_symbols | ||
| if sym.is_Symbol and pattern.match(str(sym)) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
What causes failure for 10+ placeholders?
There was a problem hiding this comment.
Lexicographical sorting:
In[1]: list(sorted(["observableParameter1_foo", "observableParameter10_foo"]))
Out[1]: ['observableParameter10_foo', 'observableParameter1_foo']
Well, not the sorting itself will fail, but the placeholder order won't match the override order in the measurement table anymore.
Adapt to the changes in PEtab-dev/PEtab#625. Placeholders are now listed explicitly. Closes PEtab-dev#390.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to the changes in PEtab-dev/PEtab#625.
Placeholders are now listed explicitly.
Closes #390.