CS: normalize code style rules [3] #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes removing the rule enforcing no space from the PHPCS native ruleset and replacing the Squiz operator spacing sniff with the PSR12 one, which will now handle enforcing of spaces around the concat operators (as well as spacing around boolean operators which was not being checked so far...).
github-actions
bot
added
Core Component: Ruleset
Core Component: File
Core Component: Fixer
Core Component: Reports
Core Component: Tokenizer
Core Component: Utils
Focus: Comments/Docblocks
Standard: Generic
Standard: PEAR
Standard: PSR1
Standard: PSR2
Standard: PSR12
Standard: Squiz
Core Component: Generators
Core Component: Config & CLI options
labels
jrfnl
deleted the
phpcs-4.x/feature/155-normalize-some-code-style-rules-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CS: single space before/after concat operators
Includes removing the rule enforcing no space from the PHPCS native ruleset and replacing the Squiz operator spacing sniff with the PSR12 one, which will now handle enforcing of spaces around the concat operators (as well as spacing around boolean operators which was not being checked so far...).
Suggested changelog entry
N/A
Related issues/external references
Part of a series of PRs to address #155