Assorted minor fixes #1251
Merged
Assorted minor fixes #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition in the `if` already takes everything that's not an array, so if we reach the `elseif` we can be sure it's a `T_ARRAY` token.
The `isset()`'s in the same condition block already take care of this.
The `isset()`'s in the same condition block already take care of this.
`$commentEnd` is retrieved by walking backwards (since the sniffs allows for attributes), so will never be `false`
The `isset()`'s in the same condition block already take care of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reports/JUnit: improve condition
Generic/DisallowYodaConditions: remove redundant condition
The condition in the
ifalready takes everything that's not an array, so if we reach theelseifwe can be sure it's aT_ARRAYtoken.PEAR/FunctionDeclaration: remove redundant conditions
The
isset()'s in the same condition block already take care of this.PSR12/ReturnTypeDeclaration: remove redundant conditions
The
isset()'s in the same condition block already take care of this.Squiz/VariableComment: remove redundant conditions
$commentEndis retrieved by walking backwards (since the sniffs allows for attributes), so will never befalseSquiz/FunctionDeclarationArgumentSpacing: remove redundant conditions
The
isset()'s in the same condition block already take care of this.PEAR/MultiLineAssignment: fix incorrect parameter passed to
findPrevious()Suggested changelog entry
N/A These fixes should have no functional impact.