Skip to content

Conversation

aarangara
Copy link

@aarangara aarangara commented Jul 24, 2018

Description

Adding table layout to the generated HTML if table element has layout style defined. This is useful when using creating PDF from PHPWord (e.g. using dompdf), otherwise the PDF does not contain any layout for table, and then it does not display any table columns which are exceeds the page width.

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

Abubakkar Rangara added 2 commits July 24, 2018 13:59
…. This is useful when using creating PDF from PHPWord (e.g. using dompdf), otherwise the PDF does not contain any layout for table.
@aarangara aarangara changed the title …Adding table layout to the generated HTML Adding table layout to the generated HTML Jul 24, 2018
@troosan troosan added this to the v0.16.0 milestone Nov 28, 2018
@troosan
Copy link
Contributor

troosan commented Nov 28, 2018

@aarangara I allowed myself to rewrite your solution a bit as the docx value for auto is autofit, which would not work with HTML (where it should be just auto).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 94.835% when pulling f472bfb on aarangara:add_html_table_layout into 7aef21f on PHPOffice:develop.

@troosan troosan merged commit 9dd5e0c into PHPOffice:develop Nov 29, 2018
@aarangara aarangara deleted the add_html_table_layout branch November 29, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants