Skip to content

Fix loading of Sharepoint document #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2018
Merged

Fix loading of Sharepoint document #1498

merged 4 commits into from
Nov 25, 2018

Conversation

Garrcomm
Copy link

@Garrcomm Garrcomm commented Nov 6, 2018

Description

When loading some documents from Sharepoint, I got notices and warnings about non-existent keys. By skipping those keys, the problem seems to be resolved.

Fixes these messages:

PHP Notice:  Undefined index: document in /home/stefan/Projects/garrcomm/PHPWord/src/PhpWord/Reader/Word2007.php on line 65
PHP Warning:  Invalid argument supplied for foreach() in /home/stefan/Projects/garrcomm/PHPWord/src/PhpWord/Reader/Word2007.php on line 65

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • [n/a] The new code is covered by unit tests (check build/coverage for coverage report)
  • [n/a] I have update the documentation to describe the changes

PHP Notice:  Undefined index: document in /home/stefan/Projects/garrcomm/PHPWord/src/PhpWord/Reader/Word2007.php on line 65
PHP Warning:  Invalid argument supplied for foreach() in /home/stefan/Projects/garrcomm/PHPWord/src/PhpWord/Reader/Word2007.php on line 65
@troosan troosan self-assigned this Nov 16, 2018
@troosan troosan changed the title Fix for undefined index Fix loading of Sharepoint document Nov 21, 2018
@troosan troosan added this to the v0.16.0 milestone Nov 22, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 94.829% when pulling d0bcfea on Garrcomm:fix-sharepoint into 586f45e on PHPOffice:develop.

@troosan troosan merged commit 78ffbff into PHPOffice:develop Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants