Skip to content

Conversation

ivanlanin
Copy link
Contributor

Guys, please review the implementation of the idea that I submitted on #200. Thanks.

@ivanlanin ivanlanin added this to the 0.11.0 milestone May 15, 2014
@Progi1984
Copy link
Member

Very good idea.

But why use a YML file ?
Why not loading SPYC with Composer (https://github.com/mustangostang/spyc/blob/master/composer.json) ?
Why not use an INI file which can be parsed with parse_ini_file and without adding a new libray ?

@ivanlanin
Copy link
Contributor Author

Why use a YML? Because that's what I did in my last project :) Using INI is indeed much easier and eliminate the need for external library. Thanks. I'll change the code and use INI instead.

Regarding external libraries, what will be our policy? Are we going to avoid external libraries as much as possible? If inevitable, will we start using require in Composer?

@Progi1984
Copy link
Member

Okay, perfect.

For external libraries, I think we should avoid external libraries, as much as possible. If inevitable, we should use Composer, with require. Good idea :)

ivanlanin added a commit that referenced this pull request May 16, 2014
@ivanlanin ivanlanin merged commit 710e147 into PHPOffice:develop May 16, 2014
@ivanlanin ivanlanin deleted the config branch May 16, 2014 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants