Deprecate Worksheet::getHashInt and Spreadsheet::getId #4639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Php8.5 may deprecate the use of
__wakeup
(it is planned, but not yet implemented, and it is convtroversial). We use it only twice. In the first instance, it just throws an exception to prevent a security exploit. This can be trivially replaced with__unserialize
.The other instance is merely to initialize a Worksheet instance variable. Converting this use to
__unserialize
is not trivial (one of the reasons for the controversy). However, I see no useful purpose for that variable. Since it has no use, there is no real need for__wakeup
, so we will just remove the routine altogether, and deprecate the variable's getter (there is no setter).A similar instance variable in Spreadsheet also serves no useful purpose, so we will deprecate its getter as well (again no setter).
This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.