Skip to content

fix: do not trigger Undefined array key "x" #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not trigger Undefined array key "x" #4669

wants to merge 1 commit into from
+123 −2

Conversation

karrakoliko
Copy link

@karrakoliko karrakoliko commented Oct 1, 2025 •
edited
Loading

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

fixes #4668

@karrakoliko karrakoliko force-pushed the fix-undefined-array-key-x branch 2 times, most recently from 4857276 to 1458af3 Compare October 1, 2025 08:37
@oleibman
Copy link
Collaborator

oleibman commented Oct 1, 2025

Can you add a unit test which will fail without your change but succeed with it?

@karrakoliko karrakoliko force-pushed the fix-undefined-array-key-x branch from 1458af3 to 7a13abb Compare October 2, 2025 07:13
@karrakoliko
Copy link
Author

@oleibman done

@karrakoliko karrakoliko force-pushed the fix-undefined-array-key-x branch from 7a13abb to 6ee6211 Compare October 2, 2025 07:20
@karrakoliko karrakoliko force-pushed the fix-undefined-array-key-x branch from 6ee6211 to 7ba35c5 Compare October 2, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
missing test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined array key "x" PHP warning
2 participants
@karrakoliko @oleibman