Added passphrase to bip39 #100
Conversation
There was a problem hiding this comment.
tACK, tested on Testnet, created a new password-protected BIP39 wallet, sent funds to it, nuked the wallet cache, and re-imported successfully.
The test wallet can be accessed with this info, for further verification:
Network: Testnet
Seed: captain stomach that wreck used buyer wire picture party federal blanket human
Pass: testtest
There's currently 100 tPIV on this wallet.
|
MPW isn't updated yet. Will try again later. |
The PR is not merged yet, needs code review and testing first - you can test the PR yourself if you wish, using our IPFS test deployments under the first button of the "Checks" section. @3point14159 |
|
Excellent work team. Just tested it with 24 word seedphrase and 999 character password using extended ASCII. There may be some special characters that mistranslate in the password input field (this happened once out of a dozen tests, but not reproducible). I'd say this is good to push to the bleeding-edge release with an announcement on the socials. This a a feature that is going to open up comparability with any assets created using any other wallet. Seriously, PIVX is really getting exciting and competitive in a weakened market; love the momentum!! |
|
PIVX is getting ripe! Should be an exciting summer! |
|
Ding - going live on Bleeding-Edge. |
|
Tested the bleeding-edge release! All systems go! Excellent work! |
Abstract
Adds the ability to create and import wallet with a user generated passphrase
What does this PR address?
MPW was missing the optional passphrase included in bip39
What features or improvements were added?
An optional passphrase input both when creating an importing a wallet
How does this benefit users?
This increases support with other wallets.
Partially addresses #80