Add View on Explorer button #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duddino
approved these changes
Mar 13, 2023
BreadJS
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR adds a simple button to the wallet UI to open the current 'master public key' in the user-preferred explorer.
Currently MPW offers no easy way of viewing the
xpub, this is a quick workaround while also allowing an easy shortcut to the explorer.Additionally this PR fixes a small bug in which a non-HD wallet in view-only mode would fail to hide the "Refresh Address" button, this is only intended for HD wallets.
What does this PR address?
It assists with the inability to view the
xpubas well as granting an explorer shortcut.What features or improvements were added?
A Dashboard shortcut to the explorer page of the current wallet public key.
How does this benefit users?
Users can access their
xpubeasier or simply quick-access an integrated PIVX explorer, alongside monitoring their address for transactions while away/outside from MPW.Alternatively, users could find it useful to import their xpub in to another MPW instance, purely for View-Only monitoring purposes.