Fix Governance Dashboard display of Over-Allocated proposals #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
requested changes
Apr 16, 2024
panleone
previously approved these changes
Apr 16, 2024
|
Perhaps we could add a third translation variable for "Over Budget" / "Over Allocated"? Trying to show the user that the proposal is valid and successfully passing, but too large to receive from the budget at current vote priority. |
To me it makes sense, and that's what pivx.org uses as well |
|
I've done two changes:
New Display: |
|
BTW, this built fine on Netlify, GitHub is just being weird. |
panleone
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR simply fixes (alongside making a little more obvious) when proposals are Over-Allocated, thus ineligible to receive their proposal payment for the given cycle.
MPW properly displays "Not Funded" on such proposals now, as well as displaying the "Passing" text in Orange to highlight the difference better.
To save a few CPU cycles and excess code, I removed the repetitive
parseInt(MonthlyPayment)for a single conversion and re-used it in the same places.These calculations are a 1:1 match with the PIVX.org website.
Before PR
After PR
Testing
To test this PR, it's suggested to attempt these user flows, or variations of these:
If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!