-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Oracle in replacement of CoinGecko #352
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work but there are some code changes I'd like to see before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK working as expected and bandwidth is reduced
Abstract
This PR integrates Labs Oracle, our in-house price aggregation system, in full replacement of our current "generic"
MarketSource
system that we implemented CoinGecko with, this integration grants a couple benefits:~45kb
to a one-time4kb
and per-call~60 bytes
.Rather than spending time integrating various external price sources alongside CoinGecko - which is time consuming, cumbersome, and harder on MPW maintainers, this PR proposes a standardised price API schema, which MPW and all other Labs projects will adopt.
Oracle has the same - and even more - currencies than CoinGecko, so no user options will be affected by this, all of their regular currencies will continue to display as expected.
Testing
To test this PR, it's suggested to attempt these user flows, or variations of these:
If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!