Fix spending txs with shield data on ledger #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
approved these changes
May 2, 2024
There was a problem hiding this comment.
tACK, nice catch.
Tested by spending this tx with my ledger e2ee9617f1764048ff0ce3ae08a60b113bf184a865b0dc0ebd703a06719ed959
on master branch the same tx was failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Split transaction needs to be told when there is additional data, such as shield on PIVX.
This PR just passes true to
hasExtraData.It doesn't need to be passed to the first
splitTransactionsince you can't create a tx with shield data on ledger anywaysMore info can be found here https://www.npmjs.com/package/@ledgerhq/hw-app-btc#splittransaction.
Testing