test: remove mempool mocks #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
added a commit
to panleone/MyPIVXWallet
that referenced
this pull request
May 3, 2024
* test: do not mock the mempool * test: remove mempool mocks * test: remove unused mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Do not mock the mempool. Mocking only makes tests boring to change each time we add a new function to the mempool.
In place of mocking the mempool I have created a utils function
setUpMainnetWallet()which sets up a mainnet wallet with a mempool (with an UTXO), a legacy master key and a dummy shield handler.The utils function reduces a lot of copy and paste, as you can see.
for future: In
setUpMainnetWalletinstead of feeding the transactions directly to the wallet, we can simulate better by creating a mock to the network (in particular a mock ofgetLatestTxs)Testing
Check that tests are still passing as before