Fix bunch of bugs #363
Merged
Fix bunch of bugs #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JSKitty
previously approved these changes
May 1, 2024
Comment on lines
-170
to
+144
| return this.getOwnedVout(tx).reduce((acc, u) => acc + u?.value ?? 0, 0); | ||
| const txid = tx.txid; | ||
|
|
||
| return tx.vout | ||
| .filter( | ||
| (_, i) => | ||
| this.getOutpointStatus( | ||
| new COutpoint({ | ||
| txid, | ||
| n: i, | ||
| }) | ||
| ) & OutpointState.OURS | ||
| ) | ||
| .reduce((acc, u) => acc + u?.value ?? 0, 0); |
There was a problem hiding this comment.
This adds quite a bit of extra code whenever we need to aggregate any kind of balance / script type / etc, are you sure we should remove the getOwnedX utility functions?
I would not reject the PR for it, but I prefer the old method.
There was a problem hiding this comment.
I don't think they will have any applications outside getDebit and getCredit, that's why I removed them.
I'd say we re-add them if they become useful again?
There was a problem hiding this comment.
A-OK with me, was just my personal comment, no blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Fix many bugs that I have accidentally added in the latest PRs
First commit: cherry-pick Duddino's commit from #354 that fixes the bug ".isLocked is not a function"
Second commit: due to bad merge
getLatestBlockswas returning early on non-shield walletsThird commit: make sure that the
blockheightis updated when toggling networkFourth and fifth commits: The mempool function
ownTransactionwas broken... So I fixed it, moved the implementation to the wallet class and removed the useless functionsgetOwnedVinandgetOwnedVoutTesting
Test that you can create txs and the wallet syncs new transactions when new block arrives