Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use country map json instead of the provided functions #366

Merged
merged 2 commits into from
May 7, 2024

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented May 3, 2024

Abstract

In addition to #355, we can import the json directly instead of using the provided functions in order to skip the import of some libraries.
This brings down the main bundle to 394KB (gzipped) from 419KB

Testing

  • Test that the auto currency detection still works

Copy link

netlify bot commented May 3, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit b4858bd
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6639041f91914f0008fe739c
😎 Deploy Preview https://deploy-preview-366--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

panleone
panleone previously approved these changes May 3, 2024
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fda6db5

@panleone panleone added the Enhancement New feature or request label May 3, 2024
@JSKitty
Copy link
Member

JSKitty commented May 3, 2024

Really odd error when using the Netlify build on PC, which causes the app to fail to load:

image

Uncaught TypeError: country_locale_map_countries_json__WEBPACK_IMPORTED_MODULE_8__.find(...) is undefined
    getDefaultCurrency settings.js:38
    js settings.js:30
    Webpack [...]

I call it odd, because my Phone loads the same Netlify build perfectly fine. 🤷‍♂️

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK b4858bd

@panleone panleone merged commit a13822b into PIVX-Labs:master May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants