Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Added postinstall.cjs for win and lin #373

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jul 23, 2024

Abstract

This is taken from #372 to ease review. This PR aims to support non-unix OSes (windows) in the postinstall phase.
First commit is cherry-picked from #372, and was made by @BreadJS
Second commit tweaks the script a bit to add support for other OSes

Testing

Run npm ci on different platforms (At least windows, linux, macOS).

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 492af9e
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/669fa369cb9bc20008fb0590
😎 Deploy Preview https://deploy-preview-373--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@BreadJS BreadJS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, lgtm!

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 492af9e

@Duddino Duddino merged commit 663862b into PIVX-Labs:master Jul 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants