Modernise some alerts #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2022 22:29
JSKitty
added
Bug
JSKitty
approved these changes
Dec 30, 2022
There was a problem hiding this comment.
tACK, thanks for the PR Valerio! 🎉
The 'issue' is not as severe/important as advertised, no losses can occur with the old alert system, it was known that it froze the thread, but since it cancels and returns anyway; it's perfectly fine to use the modern createAlert system, thanks for the improvement! 💜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I am Valerio Laera, bug solver, and I found a Time based vulnerability that blocks the thread and can make you lose PIVX.
Fixed by switching to createAlert.
Tested on linux ubuntu ssd external and internal 1tb, cpu ryzen 7 5800x, 16gb ram