Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump protocol #70

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Bump protocol #70

merged 1 commit into from
Jan 3, 2023

Conversation

Liquid369
Copy link

@Liquid369 Liquid369 commented Jan 2, 2023 •
edited
Loading

Abstract

Masternode.js was setting protocol versions, its now moved into cChainParams

  • Below is for LMP (Labs Micro Proposals), how your PR is rewarded PIVX: this'll help your PR be rewarded faster by the DAO!

What does this PR address?

Masternode.js was setting protocol, now its in the same place as many other chainparams for easier updating.

What features or improvements were added?

Refactoring protocol back into chainparams

How does this benefit users?

Easier for users to modify/update protocol versions

@Liquid369 Liquid369 requested a review from Duddino January 2, 2023 23:39
Duddino
Duddino approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Liquid369 Liquid369 requested review from JSKitty and panleone January 3, 2023 00:33
panleone
panleone approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@JSKitty JSKitty added Enhancement New feature or request Minor (~45 PIV) labels Jan 3, 2023
JSKitty
JSKitty approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, checked against PIVX Core and referred code looks sound.

@JSKitty JSKitty merged commit c3385dd into PIVX-Labs:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panleone panleone panleone approved these changes

@JSKitty JSKitty JSKitty approved these changes

@Duddino Duddino Duddino approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liquid369 @panleone @JSKitty @Duddino