Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified PR template to include comments #71

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Modified PR template to include comments #71

merged 1 commit into from
Jan 5, 2023

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jan 5, 2023 •
edited
Loading

Based on how other PR descriptions were written I think that it's better if the descriptions are changed to comments instead of quotes

@Liquid369
Copy link

uTACK

I think this will be a perpetual refinement as we open PR's with the template to assess needs and learn from them.

JSKitty
JSKitty approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, good note! I'm not sure why I didn't think of this, but it's a much better style to use. 👍

@JSKitty JSKitty added Documentation Improvements or additions to documentation Enhancement New feature or request Minor (~45 PIV) labels Jan 5, 2023
@JSKitty JSKitty merged commit ab49821 into PIVX-Labs:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSKitty JSKitty JSKitty approved these changes

@Liquid369 Liquid369 Liquid369 approved these changes

Assignees

@Duddino Duddino

Labels
Documentation Improvements or additions to documentation Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Duddino @Liquid369 @JSKitty