Fixed ledger not working #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
added
Bug
JSKitty
requested changes
Jan 23, 2023
There was a problem hiding this comment.
There's a few issues remaining, tested on Brave + Ledger Nano S;
- Ledger error codes aren't being translated in to English correctly.
- Many "String Templates" aren't being filled in the notifications.
But functionally, I'm able to derive new addresses perfectly fine, and verify them, all as usual.
added 2 commits
January 25, 2023 17:07
JSKitty
approved these changes
Jan 27, 2023
panleone
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Ledger wasn't working because of the library being updated (I think?) when switching to webpack
What does this PR address?
Fix ledger
What features or improvements were added?
Fix ledger
How does this benefit users?
They can sue ledger