Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PWA manifest, UI & service #76

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Implement PWA manifest, UI & service #76

merged 2 commits into from
Jan 29, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Jan 27, 2023

Abstract

This PR sets the foundation for converting MPW in to a Progressive Web App, essentially a hybrid between a Web and Native app, it's now natively install-able on supported browsers and devices.

Now MPW can additionally utilise more OS-level features (like 'Sharing' on android, or deep links / app redirects, so clicking a "Pay with MPW" button could open the MPW mobile app).

For example, Brave on Android now offers an "Install" button for MPW, as a standalone - but Chromium-based container app.

You can test my live version of this PR on any PWA-supported mobile browser, and install MPW here: https://jskitty-repos.github.io/MyPIVXWallet/

image

image

* Add PWA manifest & icons
* Implement native service worker
@JSKitty JSKitty self-assigned this Jan 27, 2023
@JSKitty JSKitty added the Enhancement New feature or request label Jan 27, 2023
@JSKitty JSKitty requested review from Duddino and Liquid369 January 27, 2023 21:33
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.
Was able to install the webapp on mobile with firefox, code looks good.

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Really nice PR, one step closer to mobile

@JSKitty JSKitty merged commit e0d8d23 into PIVX-Labs:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants