Prices + CoinGecko integration #81
Conversation
A prices system has been added to MPW, made to support multiple price providers in the future, as well as with existing multi-currency support and persistent user preference, defaulting to USD otherwise. Some trivial cleanup was also done, along with linting and prettier being ran, catching a few out-of-scope files, better sooner than later.
|
ESLint/Prettier did not take kindly to global.js 408-415 😂 |
| * CoinGecko's endpoint for PIVX data, optimised for least bandwidth | ||
| * - No localisation, tickers, community data, developer data or sparklines | ||
| */ | ||
| export const COINGECKO_ENDPOINT = |
There was a problem hiding this comment.
I think we should keep this in chain_params, and if it's null for the current chain we can either remove the price or set it to 0, this way testnet coins don't display mainnet prices
There was a problem hiding this comment.
I don't think there will ever be an instance where non-mainnet has a price (so "alternative" price tracking or per-network prices wouldn't really be useful).
But for consistency, I think keeping the prices as-is on all networks is fine, so tPIV would still show a value to keep the UI consistent for testing purposes, thoughts?
There was a problem hiding this comment.
I'm still not convinced about this, tPIV should be valued at 0$, but it seems like i'm alone on this, since it's a small detail I think we can merge
Abstract
A prices system has been added to MPW, made to support multiple price providers in the future, as well as with existing multi-currency support (~61 currencies) and persistent user preference, defaulting to USD otherwise.
Some trivial cleanup was also done, along with linting and prettier being ran, catching a few out-of-scope files, better sooner than later!
What does this PR address?
This PR finishes the "display currency" functionality for the Dashboard UI, as well as making it easy in the future to display "conversion currencies" in future screens, like seeing your Stakes in USD or BTC, or having a "Send USD" option, which sends the equivalent of PIVX your favored currency.
What features or improvements were added?
A modular price system, along with multi-currency support and persistent user settings for each currency.
How does this benefit users?
Users can now view their PIVX in equivalent display currencies, and customise their currency out of a large selection from CoinGecko in the MPW settings, which is persisted across sessions.