Add Contested Proposals filtering #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help "dust away" and disincentivise spam or malicious proposals, this commit ensures proposals with less than 25% net consensus (i.e; 75% downvotes) are considered Contested Proposals, and put in to a lower display state on MPW, with slightly lowered opacity and stuffed at the bottom of the Governance menu, along with an explainer sub-text to educate the user on these proposals.
panleone
requested changes
Feb 22, 2023
A minimum requirement for votes has been added before a proposal will be considered for the Contested category (100 votes) to prevent young proposals being abused in the DAO, and the filtering for 'finished' proposals was lightly refactored to include filtering directly, instead of post-call manually.
Duddino
reviewed
Feb 22, 2023
As suggested by Duddino Co-authored-by: Duddino <47313600+Duddino@users.noreply.github.com>
Duddino
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
To help "dust away" and disincentivise spam or malicious proposals, this PR ensures proposals with less than 25% net consensus (i.e; 75% downvotes) are considered Contested Proposals.
The only exception is proposals with less than 100 votes, to prevent "downvote bombing" on young proposals.
Contested Proposals are effectively "punished" by:
This is purely a display change, there's no change in voting functionality, the user still has full and total freedom to vote on proposals they wish; the PR does not intend to harm the average proposal, but act as a 'net' for proposals that are most likely to be spam or otherwise malicious.
As usual, related code was also cleaned up and simplified slightly, as well as given JSDoc coverage and translation templates.
What does this PR address?
It addresses possible spam or ill-intent proposals by lowering their presence in the Governance menu - the PR intends to balance "Freedom" and "Censoring" in a way that clearly discourages spam proposals, without impairing the freedom of users.
What features or improvements were added?
A "Contested Proposals" table to the Governance menu, which displays exclusively proposals with a net of 25% or less Net Upvotes or equally 75% Downvotes.
How does this benefit users?
This should help guide users' attention away from clearly-malicious proposals, such as spam, which clears up the primary Governance Proposals section for well-vetted proposals by the DAO.