Redesign wallet unlock flow #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BreadJS
previously approved these changes
Mar 5, 2023
Duddino
previously approved these changes
Mar 6, 2023
Liquid369
approved these changes
Mar 7, 2023
Duddino
pushed a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Mar 10, 2023
* Redesign wallet unlock flow * Run Prettier * Add prompt auto-focus * Run Prettier
Duddino
pushed a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Mar 10, 2023
* Redesign wallet unlock flow * Run Prettier * Add prompt auto-focus * Run Prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR massively simplifies the
Action <---> Unlockflow, instead of simply alerting the user to unlock MPW themselves via a notification, MPW now prompts the user to unlock mid-action, continuing the action upon successful unlock, or cancelling the action upon rejection of the password dialog.Additionally, the password prompt may have custom text to give the user better context, and the prompt system also now auto-focuses on the first input within a prompt (if any is given), removing another unnecessary click.
Overall, this is intended to be a neat UX overhaul that reduces some annoying friction in the wallet UI.
What does this PR address?
It addresses an issue in which users were getting confused and/or encountering a lot of friction using MPW due to the "View Only" system, this PR removes that friction by making Unlocking a seamless process that does not require interrupting actions or cancelling them in order to unlock.
What features or improvements were added?
When the wallet is locked and the user attempts an action requiring an unlock: MPW now prompts appropriately mid-action without needing to "back out" the action, open the Dashboard, unlock, and re-visit, which was far too many unnecessary steps.
How does this benefit users?
It massively simplifies the experience when it comes to Locking/Unlocking a user's wallet, reducing many unnecessary clicks, saving time, and resolving confusion.