Nuke depreciated FontAwesome files #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the CSS size by around ~40kb, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Prior to webpack, MPW included FontAwesome v6.x files manually - these files are still in the repo even though they're no longer used (as FA is now imported through webpack as an NPM package), and are now removed.
This PR additionally switches the new version of FA to use minimised
.min.cssinstead of full.cssfiles, which reduces MPW's bandwidth use by ~40kb.What does this PR address?
This PR simply removes an unused version of FontAwesome from the repository, and switches the existing FontAwesome to a minimised version, decreasing the loading time of MPW.
What features or improvements were added?
Unused files were removed from the repository, and the new FontAwesome was slightly optimised.
How does this benefit users?
MPW now loads slightly faster, due to using minimised FontAwesome CSS rather than full CSS files.