Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Icons Redesign #98

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Status Icons Redesign #98

merged 6 commits into from
Mar 8, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Mar 7, 2023

Abstract

The old 'status' system for MPW looked extremely clunky, inconsistent, and used too much "screen space".

This PR redesigns MPW 'statuses' to be FontAwesome icon-based with descriptive Bootstrap Tooltips upon hover, all icons are clickable, some will totally hide when disabled (i.e: Debug Mode), and some will switch icon accordingly to their mode, like Internet Access.

Production:
image

Pull Request:
image

What does this PR address?

This PR redesigns the Status system to an 'icon bar' with status icons and descriptive tooltips, massively reducing screen-space used, and giving full consistency to any existing and future MPW statuses that need to be displayed to the user.

What features or improvements were added?

A redesigned Status Bar with icons and descriptive tooltips.

How does this benefit users?

It's much nicer on the eyes, easy to understand, and uses far less screen real-estate, which helps draw the user's focus to where it's needed (the core app), only displaying verbose info upon hover.

@JSKitty JSKitty added the Enhancement New feature or request label Mar 7, 2023
@JSKitty JSKitty self-assigned this Mar 7, 2023
Liquid369
Liquid369 previously approved these changes Mar 7, 2023
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 459c158

With a minor nit
Screenshot 2023-03-07 at 9 38 06 AM
This icon does not correspond too much with
Screenshot 2023-03-07 at 9 38 25 AM
This icon, so maybe we can make them the same for both

@JSKitty JSKitty requested a review from Liquid369 March 7, 2023 15:49
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now!
tACK a5d34ec

Copy link
Member

@Luke-Larsen Luke-Larsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks great
tACK a5d34ec

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@JSKitty JSKitty merged commit ae6aa2c into master Mar 8, 2023
Duddino pushed a commit to Duddino/MyPIVXWallet that referenced this pull request Mar 10, 2023
* Status Icons Revamp

* Hide some icons by default

* Add clarified comment

* Move ptr cursor to icons instead of container

* Match Testnet icons

* Run Prettier
Duddino pushed a commit to Duddino/MyPIVXWallet that referenced this pull request Mar 10, 2023
* Status Icons Revamp

* Hide some icons by default

* Add clarified comment

* Move ptr cursor to icons instead of container

* Match Testnet icons

* Run Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants