Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benefits totals to aggregate table #120

Merged
merged 5 commits into from
Jun 24, 2020

Conversation

jdebacker
Copy link
Member

This PR seeks to address issue #119 by adding benefits totals to the aggregate tables.

@jdebacker
Copy link
Member Author

I've also changed labels for the rows of the aggregate table to deal with Issue #117.

@MattHJensen
Copy link
Contributor

MattHJensen commented Jun 19, 2020

@jdebacker, thanks for this PR (and in Tax-Calculator)! Would you mind adding a screenshot of the modified table to a comment?

I am wondering specifically if it looks odd to have revenues and outlays in the same table, and if anything needs to be done visually to separate them. Here is CBO in their January 2020 budget outlook at pg 7:

image

@jdebacker
Copy link
Member Author

@MattHJensen Here is a screen shot of the updated liabilities table:

Screen Shot 2020-06-20 at 8 11 36 PM

@MattHJensen
Copy link
Contributor

Thanks @jdebacker, that seems fine for now. We can always spruce it up later!

@andersonfrailey, this is ready for you to take a look at.

@andersonfrailey
Copy link
Collaborator

Everything looks good to me now. Will merge tomorrow afternoon unless there are any new concerns raised.

@andersonfrailey andersonfrailey merged commit d1f66ba into PSLmodels:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compute studio enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants