Missing field properties added #149
Conversation
WalkthroughThe pull request introduces extensive modifications to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/main/environment/common_example.properties (1)
93-114: Standardize configuration format and add parameter documentation
- Use consistent notation (either dot or hyphen) for property names
- Add documentation for each parameter including:
- Valid ranges
- Default values
- Impact on system behavior
Example format:
# Duration in minutes for CZ operations # Range: 30-60, Default: 40 cz-duration=40
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/environment/common_example.properties(4 hunks)
🔇 Additional comments (1)
src/main/environment/common_example.properties (1)
59-88: Improve scheduler configurations documentation and organization
- Consider adding detailed comments explaining the purpose and impact of each scheduler
- Group related schedulers together (e.g., all CTI-related schedulers)
- Verify the frequency of schedulers running every 1-5 minutes to ensure they don't overload the system
| ##commented the below lines as it is already defined above | ||
| # spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr? | ||
| encDbUserName=zFlYsp9Z0s+lRvLM15A3g/Ba0w8VGs/1usuW7EsGF3k= | ||
| encDbPass=JGGAGn5wTlrbTLUHY+5BzfBa0w8VGs/1usuW7EsGF3k= | ||
| spring.datasource.driver-class-name=com.mysql.jdbc.Driver | ||
|
|
||
| secondary.datasource.url=<Enter DB_REPORTING URL here> | ||
| secondary.datasource.username=<Enter your DB_REPORTING username> | ||
| secondary.datasource.password=<Enter your DB_REPORTING password> | ||
| secondary.datasource.url=<Enter DB_REPORTING URL here> | ||
| secondary.datasource.driver-class-name=com.mysql.jdbc.Driver |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider security improvements for database configurations
- Consider using environment variables or a secure vault for sensitive credentials
- Update the deprecated MySQL driver class
-secondary.datasource.driver-class-name=com.mysql.jdbc.Driver
+secondary.datasource.driver-class-name=com.mysql.cj.jdbc.Driver📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ##commented the below lines as it is already defined above | |
| # spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr? | |
| encDbUserName=zFlYsp9Z0s+lRvLM15A3g/Ba0w8VGs/1usuW7EsGF3k= | |
| encDbPass=JGGAGn5wTlrbTLUHY+5BzfBa0w8VGs/1usuW7EsGF3k= | |
| spring.datasource.driver-class-name=com.mysql.jdbc.Driver | |
| secondary.datasource.url=<Enter DB_REPORTING URL here> | |
| secondary.datasource.username=<Enter your DB_REPORTING username> | |
| secondary.datasource.password=<Enter your DB_REPORTING password> | |
| secondary.datasource.url=<Enter DB_REPORTING URL here> | |
| secondary.datasource.driver-class-name=com.mysql.jdbc.Driver | |
| ##commented the below lines as it is already defined above | |
| # spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr? | |
| encDbUserName=zFlYsp9Z0s+lRvLM15A3g/Ba0w8VGs/1usuW7EsGF3k= | |
| encDbPass=JGGAGn5wTlrbTLUHY+5BzfBa0w8VGs/1usuW7EsGF3k= | |
| spring.datasource.driver-class-name=com.mysql.jdbc.Driver | |
| secondary.datasource.url=<Enter DB_REPORTING URL here> | |
| secondary.datasource.username=<Enter your DB_REPORTING username> | |
| secondary.datasource.password=<Enter your DB_REPORTING password> | |
| secondary.datasource.driver-class-name=com.mysql.cj.jdbc.Driver |
|
@Asp-Codes a lot of these variables look common across environments. Can we keep it application.properties (and remove from test.properties - from where I guess you copied from)? |
Yes that is the ideal way but currently test dev and ci all these contain variables.Only in the common they are missing so I just added in it. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/environment/common_example.properties (1)
92-113: Document configuration parametersNew configuration parameters lack documentation about their purpose and impact:
cz-duration=40everwellCalendarDuration=15lonicPageSize=10callRetryConfiguration=3avniRegistrationLimit=7Add comments explaining:
- The purpose of each parameter
- The impact of modifying these values
- The units of measurement (where applicable)
- The recommended ranges for these values
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/environment/common_example.properties(5 hunks)
🔇 Additional comments (6)
src/main/environment/common_example.properties (6)
3-14: Security: Use secure database configuration practicesThe database configuration has several security concerns:
- Default credentials (root/1234) should not be used
- Using deprecated MySQL driver
- Sensitive credentials should be externalized
58-87: Review scheduler configurations and resource impactSeveral schedulers are configured to run frequently:
- CTI data check runs daily at 12:10 AM
- NHM dashboard runs daily at 12:01 AM
- Everwell data sync runs every 5 minutes when enabled
Please verify:
- The resource impact of running these schedulers
- Why certain schedulers are enabled by default
- If the cron expressions align with business requirements
Consider implementing a rate limiter or circuit breaker to prevent system overload from frequent scheduler executions.
114-117: Externalize hardcoded IP addressThe NHM agent URL contains a hardcoded IP address which should be externalized following the existing pattern using environment variables.
168-168: Secure the file base path configurationThe file base path configuration requires security validation and documentation.
134-136: Verify port changes for Everwell endpointsThe port for Everwell endpoints has been changed from 8080 to 8083. Please verify:
- If this change is coordinated with the Everwell service deployment
- If all related services are aware of this port change
27-31: Clarify identity service configurationThe comment "not sure abt this" suggests uncertainty about the identity configuration. Please:
- Verify if port 8094 is the correct port for identity services
- Document the purpose of each identity endpoint
- Remove the uncertain comment once verified
✅ Verification successful
Remove uncertainty comment and improve documentation
The identity configurations are valid and actively used in
IdentityBeneficiaryServiceImpl.java:
identity-api-url: Regular identity service endpointidentity-1097-api-url: 1097-specific identity service endpointPlease:
- Remove the "not sure abt this" comment as both configurations are necessary
- Add descriptive comments explaining the purpose of each endpoint
- Consider using placeholders like other environment files:
<Enter your socket address here>🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if these identity endpoints are referenced elsewhere rg "identity-api-url|identity-1097-api-url" --type propertiesLength of output: 98
Script:
#!/bin/bash # Search for identity configurations and URLs without file type restriction rg -l "identity-api-url|identity-1097-api-url|localhost:8094/identity-0.0.1|localhost:8094/1097identityapi" # Search for port 8094 usage rg "8094" # Find all properties files fd ".*\.properties$"Length of output: 1001
Script:
#!/bin/bash # Check identity configurations across all environments for f in src/main/environment/common_{ci,dev,test,uat}.properties; do echo "=== $f ===" rg "identity.*api.*url" "$f" done # Check how these properties are used in the service rg -A 5 "identity.*api.*url" src/main/java/com/iemr/common/service/beneficiary/IdentityBeneficiaryServiceImpl.java # Check if there's documentation about these endpoints fd "README|CONTRIBUTING|docs" -e mdLength of output: 8067
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/main/environment/common_example.properties (1)
95-114: Document configuration parametersNew configuration parameters have been added without documentation explaining their purpose and valid values:
- cz-duration
- TMprescriptionTemplate
- everwellCalendarDuration
- lonicPageSize
- callRetryConfiguration
- avniRegistrationLimit
Add comments explaining:
- Purpose of each parameter
- Valid value ranges
- Impact on system behavior
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/environment/common_example.properties(5 hunks)
🔇 Additional comments (4)
src/main/environment/common_example.properties (4)
115-118: Replace hardcoded IP with environment variableThe previous review already identified this issue. The hardcoded IP address should be externalized following the existing pattern using environment variables.
-nhm.agent.real.time.data.url= http://175.101.1.83/apps/utility/alive_api.php +nhm.agent.real.time.data.url= ${NHM_AGENT_HOST}/apps/utility/alive_api.php
169-169: Add security validation for file base pathThe previous review already identified this security concern. The file base path needs proper validation and security measures:
- Path validation within allowed boundaries
- Path sanitization
- Documentation of expected format and restrictions
61-88: Review scheduler configurationsSeveral scheduler configurations have been added with specific concerns:
- Multiple schedulers with overlapping purposes
- Some schedulers are enabled by default in example configuration
- Cron expressions might need validation
Run this script to analyze scheduler patterns across environments:
✅ Verification successful
Scheduler configurations are appropriate and well-structured
The review concerns have been analyzed and found to be unfounded:
- Each scheduler serves a distinct purpose without functional overlap
- The enabled schedulers (CTI data check and NHM dashboard) in the example configuration are appropriate for core functionality
- All cron expressions are valid and scheduled at non-conflicting intervals
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check scheduler configurations across different environments fd -e properties -x rg "start-.*-scheduler|cron-scheduler-.*" # Validate cron expressions fd -e properties -x rg "cron.*=.*"Length of output: 3975
28-32: Remove redundant URL suffixesBased on the previous discussion between drtechie and Asp-irin, the
/identity-0.0.1suffix is not needed when running services locally.Please verify if these changes align with the local development setup:
-identity-api-url = http://localhost:8094/ +identity-api-url = http://localhost:8094 -identity-1097-api-url = http://localhost:8094/ +identity-1097-api-url = http://localhost:8094
| @@ -1,20 +1,20 @@ | |||
| # local env | |||
| server.port=8083 | |||
There was a problem hiding this comment.
Security: Avoid committing sensitive credentials
The database configuration exposes sensitive credentials:
- Plain text passwords
- Root user access
- Direct database URLs
Consider these security improvements:
- Use environment variables or secure vault for credentials
- Create dedicated database users with limited privileges
- Add placeholders instead of actual values in example properties
-spring.datasource.username=root
-spring.datasource.password=1234
+spring.datasource.username=${DB_USER}
+spring.datasource.password=${DB_PASSWORD}Also applies to: 4-6, 13-15
| everwell1097userAuthenticate = http://10.208.122.38:8083/user/userAuthenticate | ||
| everwelluserAuthenticate = https://beta-hub.everwell.org/token | ||
| everwellRegisterBenficiary = http://10.208.122.38:8080/commonapi-v1.0/beneficiary/create | ||
| everwellRegisterBenficiary = http://10.208.122.38:8083/beneficiary/create |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Standardize API endpoint configuration
The API endpoints contain inconsistent port usage and hardcoded IPs:
- Some endpoints use HTTPS while others use HTTP
- Hardcoded IP (10.208.122.38) should be configurable
- Port 8083 is hardcoded
Standardize the configuration:
-everwell1097userAuthenticate = http://10.208.122.38:8083/user/userAuthenticate
+everwell1097userAuthenticate = ${EVERWELL_API_BASE_URL}/user/userAuthenticate
-everwellRegisterBenficiary = http://10.208.122.38:8083/beneficiary/create
+everwellRegisterBenficiary = ${EVERWELL_API_BASE_URL}/beneficiary/create📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| everwell1097userAuthenticate = http://10.208.122.38:8083/user/userAuthenticate | |
| everwelluserAuthenticate = https://beta-hub.everwell.org/token | |
| everwellRegisterBenficiary = http://10.208.122.38:8080/commonapi-v1.0/beneficiary/create | |
| everwellRegisterBenficiary = http://10.208.122.38:8083/beneficiary/create | |
| everwell1097userAuthenticate = ${EVERWELL_API_BASE_URL}/user/userAuthenticate | |
| everwelluserAuthenticate = https://beta-hub.everwell.org/token | |
| everwellRegisterBenficiary = ${EVERWELL_API_BASE_URL}/beneficiary/create |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/main/environment/common_example.properties (2)
95-114: Document configuration parametersPlease add comments explaining:
- The purpose and valid ranges for
cz-duration,everwellCalendarDuration- The impact of
callRetryConfigurationandavniRegistrationLimit- The significance of
lonicPageSize
135-137: Standardize API endpoint configurationConsider using environment variables for the base URL to make it configurable across environments:
-everwell1097userAuthenticate = http://localhost:8083/user/userAuthenticate -everwellRegisterBenficiary = http://localhost:8083/beneficiary/create +everwell1097userAuthenticate = ${COMMON_API_BASE_URL}/user/userAuthenticate +everwellRegisterBenficiary = ${COMMON_API_BASE_URL}/beneficiary/create
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/environment/common_example.properties(5 hunks)
🔇 Additional comments (4)
src/main/environment/common_example.properties (4)
2-15: Security: Avoid committing sensitive credentialsThe database configuration exposes sensitive credentials in plain text. This is a security risk that was previously identified.
28-32: LGTM! URL simplification implementedThe identity API URLs have been simplified as discussed in the PR comments.
115-118: Hardcoded IP should be externalizedThe hardcoded IP in the NHM agent URL should be externalized following existing patterns.
169-169: Add security validation for file base pathThe file base path configuration requires security validation to prevent directory traversal attacks.
| spring.datasource.password=1234 | ||
|
|
||
| spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr?autoReconnect=true&useSSL=false | ||
| # spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr?autoReconnect=true&useSSL=false |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
src/main/environment/common_example.properties (4)
2-2:⚠️ Potential issueSecurity: Avoid committing sensitive credentials
The database configuration exposes sensitive credentials:
- Plain text passwords
- Root user access
- Direct database URLs
Consider these security improvements:
- Use environment variables or secure vault for credentials
- Create dedicated database users with limited privileges
- Add placeholders instead of actual values in example properties
-server.port=8083 +server.port=${SERVER_PORT} -spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr -spring.datasource.username=root -spring.datasource.password=1234 +spring.datasource.url=${DB_URL} +spring.datasource.username=${DB_USER} +spring.datasource.password=${DB_PASSWORD} -secondary.datasource.username=root -secondary.datasource.password=1234 -secondary.datasource.url=jdbc:mysql://localhost:3306/db_reporting +secondary.datasource.url=${SECONDARY_DB_URL} +secondary.datasource.username=${SECONDARY_DB_USER} +secondary.datasource.password=${SECONDARY_DB_PASSWORD}Also applies to: 4-6, 13-15
61-88: 🛠️ Refactor suggestionOptimize scheduler configurations to prevent resource contention
The scheduler configurations need optimization:
- Multiple schedulers running at high frequency could impact system performance
- Consider staggering the schedulers to prevent overlap
- Document the rationale for chosen intervals
Specific concerns:
cron-scheduler-everwelldatasyncruns every 5 minutescron-scheduler-nhmdashboardruns every hour at minute 1cron-avni-registrationruns every minuteConsider:
- Increasing intervals for high-frequency jobs
- Adding appropriate start time offsets to prevent concurrent execution
- Adding comments explaining the business need for each frequency
119-122:⚠️ Potential issueHardcoded IP should be externalized
Replace hardcoded IP with configurable hostname following existing patterns.
-nhm.agent.real.time.data.url= http://175.101.1.83/apps/utility/alive_api.php +nhm.agent.real.time.data.url=${NHM_AGENT_HOST}/apps/utility/alive_api.php
173-173:⚠️ Potential issueAdd security validation for file base path
The file base path needs security validation:
- Validate path is within allowed boundaries
- Implement path sanitization
- Document format and restrictions
-fileBasePath =<Enter your required basepath here>/Doc +# Base path for document storage +# Must be within /var/lib/amrit/docs +fileBasePath=${AMRIT_DOCS_PATH}/Doc
🧹 Nitpick comments (2)
src/main/environment/common_example.properties (2)
28-32: Remove trailing slashes from API URLsTrailing slashes in API base URLs can cause issues with path concatenation. Also, consider using environment variables for the host and port.
-identity-api-url = http://localhost:8094/ -identity-1097-api-url = http://localhost:8094/ -genben-api=http://localhost:8092/ +identity-api-url = ${IDENTITY_API_HOST}:${IDENTITY_API_PORT} +identity-1097-api-url = ${IDENTITY_1097_API_HOST}:${IDENTITY_1097_API_PORT} +genben-api=${GENBEN_API_HOST}:${GENBEN_API_PORT}
99-117: Document configuration valuesThe newly added configuration values lack documentation explaining their purpose and acceptable ranges.
Add comments explaining:
- Purpose of each configuration
- Valid value ranges
- Impact of modifications
Example:
-cz-duration=40 +# Duration in minutes for the comfort zone window +# Valid range: 30-60 minutes +cz-duration=40 -everwellCalendarDuration=15 +# Calendar duration in days for Everwell appointments +# Valid range: 7-30 days +everwellCalendarDuration=15
| everwellGetPatientAdherenceUrl = https://beta-hub.everwell.org/Api/Patients/CurrentMonthMissedAdherence?Page= | ||
| everwellEditSecondaryPhoneNo = https://beta-hub.everwell.org/Api/Patients/EditPhoneNumber | ||
| everwell1097userAuthenticate = http://10.208.122.38:8080/commonapi-v1.0/user/userAuthenticate | ||
| everwell1097userAuthenticate = http://localhost:8083/user/userAuthenticate |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Standardize API endpoint configuration
The Everwell API endpoints should use environment variables for consistency with other configurations.
-everwell1097userAuthenticate = http://localhost:8083/user/userAuthenticate
-everwellRegisterBenficiary = http://localhost:8083/beneficiary/create
+everwell1097userAuthenticate = ${EVERWELL_API_BASE_URL}/user/userAuthenticate
+everwellRegisterBenficiary = ${EVERWELL_API_BASE_URL}/beneficiary/createAlso applies to: 141-141
|
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
src/main/environment/common_example.properties (4)
2-2:⚠️ Potential issueSecurity: Avoid committing sensitive credentials
The database configuration exposes sensitive credentials in plain text. This is a security risk.
Consider using environment variables or a secure vault for credentials:
-server.port=8083 +server.port=${SERVER_PORT} -spring.datasource.url=jdbc:mysql://localhost:3306/db_iemr -spring.datasource.username=root -spring.datasource.password=1234 +spring.datasource.url=${DB_URL} +spring.datasource.username=${DB_USER} +spring.datasource.password=${DB_PASSWORD} -secondary.datasource.username=root -secondary.datasource.password=1234 -secondary.datasource.url=jdbc:mysql://localhost:3306/db_reporting +secondary.datasource.username=${SECONDARY_DB_USER} +secondary.datasource.password=${SECONDARY_DB_PASSWORD} +secondary.datasource.url=${SECONDARY_DB_URL}Also applies to: 4-6, 12-14
60-87: 🛠️ Refactor suggestionOptimize scheduler configurations
The scheduler configurations need optimization to prevent resource contention.
- High-frequency schedulers might impact system performance:
cron-scheduler-everwelldatasyncruns every 5 minutescron-scheduler-nhmdashboardruns every hour at minute 1- Consider staggering the schedulers to prevent overlap
- Use environment variables for better configurability:
-start-ctidatasync-scheduler=false -cron-scheduler-ctidatasync=0 0 2 */2 * ? +start-ctidatasync-scheduler=${CTI_SYNC_ENABLED:false} +cron-scheduler-ctidatasync=${CTI_SYNC_CRON:0 0 2 */2 * ?} -start-everwelldatasync-scheduler=false -cron-scheduler-everwelldatasync=0 0/5 * * * ? * +start-everwelldatasync-scheduler=${EVERWELL_SYNC_ENABLED:false} +cron-scheduler-everwelldatasync=${EVERWELL_SYNC_CRON:0 0/30 * * * ? *}
118-121: 🛠️ Refactor suggestionReplace hardcoded IP with environment variable
The NHM agent URL contains a hardcoded IP address.
Apply this diff to externalize the configuration:
-nhm.agent.real.time.data.url= http://175.101.1.83/apps/utility/alive_api.php +nhm.agent.real.time.data.url=${NHM_AGENT_URL}/apps/utility/alive_api.php
138-141: 🛠️ Refactor suggestionStandardize API endpoint configuration
The Everwell API endpoints should use environment variables for consistency.
Apply this diff:
-everwell1097userAuthenticate = http://localhost:8083/user/userAuthenticate -everwellRegisterBenficiary = http://localhost:8083/beneficiary/create +everwell1097userAuthenticate = ${EVERWELL_API_BASE_URL:http://localhost:8083}/user/userAuthenticate +everwellRegisterBenficiary = ${EVERWELL_API_BASE_URL:http://localhost:8083}/beneficiary/create
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/environment/common_example.properties(5 hunks)
🔇 Additional comments (1)
src/main/environment/common_example.properties (1)
172-172: Add security validation for file base pathThe file base path configuration needs security validation.
Run the following script to check for path validation in the codebase:
#!/bin/bash # Check for file path validation rg -B 2 -A 2 "fileBasePath" # Check for common directory validation patterns rg -B 2 -A 2 "mkdirs|exists|isDirectory|createDirectories"
| identity-api-url = http://localhost:8094/ | ||
| #Verify whether 1097 and identity are same? | ||
| identity-1097-api-url = http://localhost:8095/ | ||
| ##Generate Benificiary Config | ||
| genben-api=http://localhost:8092/ |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove unnecessary path segments from API URLs
Based on the PR comments discussion between drtechie and Asp-irin, the /identity-0.0.1 path segment should be removed when running locally.
Apply this diff to update the URLs:
-identity-api-url = http://localhost:8094/
-identity-1097-api-url = http://localhost:8095/
-genben-api=http://localhost:8092/
+identity-api-url = ${IDENTITY_API_URL:http://localhost:8094}
+identity-1097-api-url = ${IDENTITY_1097_API_URL:http://localhost:8095}
+genben-api=${GENBEN_API_URL:http://localhost:8092}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| identity-api-url = http://localhost:8094/ | |
| #Verify whether 1097 and identity are same? | |
| identity-1097-api-url = http://localhost:8095/ | |
| ##Generate Benificiary Config | |
| genben-api=http://localhost:8092/ | |
| identity-api-url = ${IDENTITY_API_URL:http://localhost:8094} | |
| #Verify whether 1097 and identity are same? | |
| identity-1097-api-url = ${IDENTITY_1097_API_URL:http://localhost:8095} | |
| ##Generate Benificiary Config | |
| genben-api=${GENBEN_API_URL:http://localhost:8092} |
📋 Description
This PR adds missing field properties to the
common_example.propertiesfile and removes redundant code to improve code practices.Summary by CodeRabbit
Configuration Updates
Scheduler Management