adding newly added grievance related properties to properties file #160
Conversation
latest pull
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
AMM-1137 | after
latest pull
AMM-1076 and AMM-1078 (PSMRI#146)
latest pull 19 jan
latest pull
WalkthroughThis pull request introduces a new configuration property, Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
updating upload artifact version to v4
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
src/main/environment/common_example.properties (1)
116-117: Verification of Grievance Property in Example Config:
The AI summary indicates that the new propertygrievanceAllocationRetryConfiguration=1should be added in this example configuration, similar to other environments. However, it is not visibly present in the provided snippet. Please confirm that this property is indeed included so that sample deployments remain consistent.src/main/resources/application.properties (3)
183-186: Ensure Placeholders Are Replaced and Securely ManagedThe newly added grievance-related properties for the base file path and JWT secret contain placeholder values. Make sure to replace
<Enter your required basepath here>and<enter the secret key>with actual, secure values during deployment. Consider managing sensitive information (likejwt.secret) via environment variables or a secure vault rather than hardcoding them in the repository.
188-191: Enforce Consistent Formatting for API URL PropertiesThe grievance API call properties use slightly different spacing around the equals sign. For example,
updateGrievanceDetails = <ENTER GRIEVANCE_API_BASE_URL>/...(with a space) versusupdateGrievanceTransactionDetails=<ENTER GRIEVANCE_API_BASE_URL>/.... Standardizing the spacing improves readability and maintains consistency across the properties file.
192-198: Correct Typographical Error and Verify Naming ConsistencyThe properties under grievance variables include a placeholder
"grievanceDataSyncDuration = <Enter Grievience Data Sync Duration>"where "Grievience" is misspelled. Additionally, verify that the naming forgrievanceUserAuthenticatealigns with your overall configuration naming conventions (consider if a name likegrievanceUserAuthenticationis more appropriate). Ensure all placeholder texts are updated prior to deployment.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
src/main/environment/common_ci.properties(1 hunks)src/main/environment/common_dev.properties(1 hunks)src/main/environment/common_example.properties(1 hunks)src/main/environment/common_test.properties(1 hunks)src/main/environment/common_uat.properties(1 hunks)src/main/resources/application.properties(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (6)
src/main/environment/common_ci.properties (1)
160-163: New Grievance Retry Configuration in CI:
The new propertygrievanceAllocationRetryConfiguration=1has been added in the CI configuration. This addition appears consistent with other environments. Also, note that the Swagger UI is set to disabled (springdoc.swagger-ui.enabled=false) in this file—please confirm that this is intentional for the CI environment.src/main/environment/common_uat.properties (1)
159-163: UAT Configuration Update:
In the UAT properties file, Swagger UI has been enabled (springdoc.swagger-ui.enabled=true) and the new propertygrievanceAllocationRetryConfiguration=1is introduced. This ensures consistency with other environments where Swagger UI is meant to be accessible. Verify that these settings meet your UAT requirements and that any dependent components are documented accordingly.src/main/environment/common_dev.properties (1)
186-190: Development Environment Configuration:
The dev configuration now explicitly enables Swagger UI (springdoc.swagger-ui.enabled=true) and adds the new propertygrievanceAllocationRetryConfiguration=1. This update appears consistent with the desired behavior across environments. Please verify that the retry value “1” aligns with the expected failure recovery logic and ensure that this configuration is clearly documented for developers working in the dev environment.src/main/environment/common_test.properties (1)
186-189: Test Environment Configuration Update:
In the test properties file, Swagger UI is now enabled (springdoc.swagger-ui.enabled=true) and the new configurationgrievanceAllocationRetryConfiguration=1is added. This is in line with the changes in other environments. Consider verifying through integration or functional tests that any components relying on this property behave as expected.src/main/resources/application.properties (2)
199-201: Review Swagger API Documentation Settings for Your DeploymentThe properties
springdoc.api-docs.enabled=trueandspringdoc.swagger-ui.enabled=trueenable API documentation features. Confirm that exposing Swagger UI is appropriate for the current environment, especially if this configuration might be applied in production where it could expose internal API details.
202-208: Validate Grievance Data Sync Scheduler and Retry ConfigurationThe grievance data synchronization block sets up the scheduler (
start-grievancedatasync-scheduler=falseandcron-scheduler-grievancedatasync=0 0/5 * * * ? *) along with the allocation retry property (grievanceAllocationRetryConfiguration=1). Double-check that these configurations meet your operational requirements across environments. For instance, confirm that scheduling is correctly disabled/enabled as intended and that the retry configuration value is consistent with your system’s retry policy.
|
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
New Features
Chores