Jwttoken implementation added for superUserAuthenticate API #206
Conversation
|
""" WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant IEMRAdminController
participant JWTService
participant Redis
participant HttpResponse
Client->>IEMRAdminController: superUserAuthenticate(request, response)
IEMRAdminController->>IEMRAdminController: Authenticate user
alt Authentication successful
IEMRAdminController->>JWTService: Generate JWT token
alt User agent is mobile
IEMRAdminController->>JWTService: Generate refresh token
IEMRAdminController->>Redis: Store refresh token JTI with expiry
else Not mobile
IEMRAdminController->>HttpResponse: Add JWT token as cookie
end
IEMRAdminController->>Redis: Store user object with 30-min TTL
IEMRAdminController-->>Client: Return response
else Authentication failed
IEMRAdminController-->>Client: Return error response
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/com/iemr/common/controller/users/IEMRAdminController.java(3 hunks)src/main/java/com/iemr/common/utils/RestTemplateUtil.java(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/main/java/com/iemr/common/controller/users/IEMRAdminController.java (1)
src/main/java/com/iemr/common/utils/UserAgentUtil.java (1)
UserAgentUtil(3-9)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: style-check / checkstyle
- GitHub Check: Analyze (java)
- GitHub Check: Build
- GitHub Check: Package-test
🔇 Additional comments (3)
src/main/java/com/iemr/common/utils/RestTemplateUtil.java (1)
43-45: LGTM! Good defensive programming practice.The null check prevents potential issues when the "JwtToken" header is not present in the incoming request, ensuring only valid JWT tokens are propagated to downstream services.
src/main/java/com/iemr/common/controller/users/IEMRAdminController.java (2)
402-402: LGTM! Method signature properly updated.The addition of
HttpServletResponse httpResponseparameter enables JWT token cookie handling, aligning with the existinguserAuthenticatemethod.
414-416: LGTM! Variable declarations are consistent.The JWT token and refresh token variables are properly declared to support the authentication enhancements.
|
📋 Description
JIRA ID: AMM-1545
Jwttoken Implementation added
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
New Features
Bug Fixes