-
Notifications
You must be signed in to change notification settings - Fork 45
Expire jwttoken time increased to one day #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe access token expiration time for JWTs has been updated in the application's configuration file, increasing the duration from 2 hours to 24 hours. The refresh token expiration setting remains unchanged. Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
π§Ή Nitpick comments (2)
src/main/resources/application.properties (2)
174-174
: Confirm the time unit forjwt.access.expiration
.
The raw value86400000
is in milliseconds (24h). Consider adding an inline comment or switching to a human-readable duration (e.g.,24h
) if supported by your configuration parser.
174-174
: Evaluate security implications of a 24-hour access token.
Extending the token validity window increases the risk if a token is compromised. Ensure this aligns with your security policy and that you have revocation or rotation mechanisms in place.
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
src/main/resources/application.properties
(1 hunks)
β° Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (java)
- GitHub Check: Build
- GitHub Check: Package-test
π Additional comments (1)
src/main/resources/application.properties (1)
174-174
: Update documentation and tests to reflect the new TTL.
Make sure any API docs, client configs, and automated tests reference the 24-hour expiration so consumers and CI validations stay in sync.
π Description
JIRA ID: AMM-1511
Jwttoken expire time increased to one day.
β Type of Change
βΉοΈ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit