Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc_pos_control: skip takeoff logic when in fixed wing mode #14985

Closed
wants to merge 1 commit into from

Conversation

RomanBapst
Copy link
Contributor

Test to see if this fixes #14933

…ng mode

- can happen if a vtol takes off as a fixed wing

Signed-off-by: RomanBapst <bapstroman@gmail.com>
@MaEtUgR
Copy link
Member

MaEtUgR commented May 27, 2020

This is likely the problem but it should just skip the takeoff ramp completely if you're in that vtol mode like when you're taking of stabilized. See https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/Takeoff/Takeoff.cpp#L49

@MaEtUgR MaEtUgR self-requested a review May 27, 2020 17:15
@RomanBapst
Copy link
Contributor Author

@MaEtUgR Thanks, can you do a PR for that?

@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Aug 29, 2020
@dagar
Copy link
Member

dagar commented Jan 10, 2021

Presumably we didn't need this?

@stale stale bot removed the stale label Jan 10, 2021
@RomanBapst
Copy link
Contributor Author

@dagar Yes, looks like this was actually not the root problem.
According to @sfuhrer this fixed it.
Closing this.

@RomanBapst RomanBapst closed this Jan 13, 2021
@MaEtUgR MaEtUgR deleted the pr-takeoff_logic branch January 18, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VTOL] Dangerous Back Transition
3 participants