-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulator: Do not kill every process with string 'px4' in the name. #6319
Conversation
…o exact match instead.
Now that I think of it, we do have a mechanism for generating binaries for different vehicles. Let me find it and see if anyone actually uses it. |
Yes, the sitl binary could be px4 or px4_${model}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binary could be px4 or px4_${model}.
…dd matching for px4_$model
Default $model is iris but executable is still just 'px4'. I guess that's fine. |
They are not necessarily the same: https://dev.px4.io/simulation-gazebo.html#starting-gazebo-and-px4-separately We need to have support for the $model case as well. |
How is this possible that my commit broke compiler detection? |
No. You can run |
I'm talking about the failed automated CI test: |
Try rebasing and pushing. That likely will fix it. |
Yes you should be fine after a rebase. This is a case where the semaphoreci config not being stored in the repo causes problems. |
Did not quite get it. (This is my first time with contributing to opensource) |
Needed for the DriverFramework. Fixes the error: 15050 SPIDevObj start failed 15142 DevObj start failed 15185 Unable to open the device path: ERROR [df_lsm9ds1_wrapper] LSM9DS1 start fail: -1 ERROR [df_lsm9ds1_wrapper] DfLsm9ds1Wrapper start failed Command 'df_lsm9ds1_wrapper' failed, returned -1
- pulls more of the travis-ci s3 deploy into the repo so we can potentially migrate to another CI system - fixed the sizes output and added verbose compiler version to cmake (#6322) - fixed filenames for firmware uploaded to s3 (was broken by the changes yesterday) - fixed some broken git version display in cmake - Makefile organization - simplified .travis.yml - added a print to know which config the nuttx patch was being applied to - docker_run.sh now respects PX4_DOCKER_REPO for setting the docker image, but defaults to the good production nuttx image
… modes) (#6323) * Fixed build error in Snapdragon Flight legacy driver mode (partially) * Fixed build error in eagle_legacy_default mode (px4muorb.h generation issue) * Fixed the snapdragon flight sanity test script (default and legacy driver modes)
- this is to work around confusion between cygwin and windows native paths - closes #6332
as it is
the velocity controller was misusing the integral part to account for the constant gravitational force offset the hover throttle from the parameter is now is now directly used as feed forward for the thrust in world z direction the integrator compensates for inaccurate paarameter but should now be idealy zero
if we control manually and are still landed, we want to stay idle until the pilot rises the throttle
… z axis until now the desired thrust was simply the absolute value of the thrust setpoint vector but a multicopter is only capable of producing thrust in its (negative) body z axis this leads to excess thrust during attitude tracking errors one important use case is: trying to land with minimal thrust in NED z axis against gravity but the position controller still correcting some small horizontal estimation errors then this prevents unwanted thrust in a completely wrong direction
…ing detection in real world scenarios
…established. This ensures the system does not tip over on landings. Tested in SITL with a GPS drift model.
* Fixed build error in Snapdragon Flight legacy driver mode (partially) * Fixed build error in eagle_legacy_default mode (px4muorb.h generation issue) * Fixed the snapdragon flight sanity test script (default and legacy driver modes) * Fixed PX4 sanity test script (removed a check msg)
F7 was missing in the CONFIG_xxx that controlled enableing the hardfault_log boot code that can save the fault log
…eck so it accepts a minimum of 5 channels. It seems that was the initial intention.
Closed due to failed CI tests. Followed up by #6377 |
Do exact match instead.
Same for gazebo.