Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update MAVLink so common includes standard (#20542)" #20596

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Revert "Update MAVLink so common includes standard (#20542)" #20596

merged 1 commit into from
Nov 15, 2022

Conversation

AlexKlimaj
Copy link
Member

This PR reverts #20542 which causes communication failure with QGC.

@dagar
Copy link
Member

dagar commented Nov 11, 2022

Any idea what's going on?

@AlexKlimaj
Copy link
Member Author

Any idea what's going on?

Nope, just that QGC doesn't like it. Flash main on hardware and see if it connects to QGC.

@dagar
Copy link
Member

dagar commented Nov 15, 2022

We need to get to the root cause here, but I'll merge in the meantime.

@dagar dagar merged commit 2e918eb into PX4:main Nov 15, 2022
@dagar dagar added the bug label Nov 15, 2022
@AlexKlimaj AlexKlimaj deleted the pr-revert-mavlink branch November 15, 2022 20:51
@hamishwillee
Copy link
Contributor

@dagar Indeed. And it might be the root cause is QGC. We need an engineer to work on this - @mrpollo can you suggest someone?

IF we don't do this, PX4 won't be taking any more MAVLink updates.

@AlexKlimaj AlexKlimaj mentioned this pull request Nov 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar Awaiting requested review from dagar

@hamishwillee hamishwillee Awaiting requested review from hamishwillee

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKlimaj @dagar @hamishwillee