Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SYS_USE_IO param #22243

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove SYS_USE_IO param #22243

merged 1 commit into from
Nov 9, 2023

Conversation

julianoes
Copy link
Contributor

@julianoes julianoes commented Oct 18, 2023

The param is not really required anymore with the actuator configuration. Also, when it is set to 0, RC doesn't work for some boards which would be nice to avoid.

If you have alternative ways to fix #22206, that's fine with me, but as it is now, the param description is a lie and this is a major regression with v1.14.

Fixes #22206

Needs to go into v1.14.

The param is not really required anymore with the actuator
configuration. Also, when it is set to 0, RC doesn't work for some
boards which would be nice to avoid.

Signed-off-by: Julian Oes <julian@oes.ch>
Copy link
Member

@dagar dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine from my perspective because if someone doesn't want to use px4io outputs they can simply not configure them now. As for RC ORB_ID(input_rc) will only be published if anything is found (CRSF and soon other protocols could still be explicitly enabled and used FMU side regardless).

Beyond that if someone has a board with a px4io and they really don't want it used at all they can simply disable it in their build, I don't think this needs to be a user accessible runtime feature.

Can anyone think of another case where it matters?

@dagar
Copy link
Member

dagar commented Oct 19, 2023

Hold on, this might still be a minor issue for fmu-v5 (pixhawk 4 vs 4 mini) and some other PAB cases.

For example we need to make sure the pixhawk 4 mini still boots cleanly without errors.

@julianoes
Copy link
Contributor Author

Can we merge this? And get it into v1.14.1?

@julianoes
Copy link
Contributor Author

julianoes commented Nov 9, 2023

Alright, no more comments, merging. Otherwise it rots I get told off for not merging early enough.

@julianoes julianoes merged commit 19b681c into main Nov 9, 2023
87 checks passed
@julianoes julianoes deleted the pr-remove-sys-use-io branch November 9, 2023 23:17
@AlexKlimaj
Copy link
Member

How does this interact on carrier boards with the RC input using the IO UART?

@julianoes
Copy link
Contributor Author

@AlexKlimaj this basically means IO is always started, and so RC should always work. The problem was that the param let us disable IO which lead to RC not working. Does that make sense?

@AlexKlimaj
Copy link
Member

@AlexKlimaj this basically means IO is always started, and so RC should always work. The problem was that the param let us disable IO which lead to RC not working. Does that make sense?

No I mean on carrier boards without an IO processor like the ARK PAB Carrier. USART6 goes to the RC connector instead of the IO MCU.

@julianoes
Copy link
Contributor Author

julianoes commented Nov 11, 2023

My guess is they should work fine but we should test it.

@mcsauder
Copy link
Contributor

Glad you merged it. Thank you.

@AlexKlimaj
Copy link
Member

ERROR [px4io] PX4IO Not Supported
INFO  [tune_control] Stopping playback...
ERROR [px4io] PX4IO Not Supported
PX4IO start failed

I am getting a constant error tune playing without a PX4IO carrier board.

@AlexKlimaj
Copy link
Member

Maybe RCS should query the manifest to check if the PX4IO is expected to be present before attempting to upgrade firmware or start the driver.

https://github.com/PX4/PX4-Autopilot/blob/main/src/drivers/px4io/px4io.cpp#L1763

@bresch
Copy link
Member

bresch commented Nov 16, 2023

@julianoes My Pixhawk4 mini does a continuous SOS beep because of this.

@julianoes
Copy link
Contributor Author

Is there a way to know whether it is a Pixhawk 4 or 4 mini? @bresch can you share the boot output and ver all?

@AlexKlimaj
Copy link
Member

@bresch @julianoes see #22368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] PPM and SBUS input not working with SYS_USE_IO = 0 on Pixhawks and Cubes
5 participants