Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxp/imxrt_common/main:Fix Breakage from a9962dc #23174

Merged
merged 4 commits into from
May 29, 2024

Conversation

davids5
Copy link
Member

@davids5 davids5 commented May 23, 2024

This was merged and will not even compile. There are babies being thrown out in the bathwater! - CI needs to be Fixed.

@davids5
Copy link
Member Author

davids5 commented May 23, 2024

This is waiting on a nuttx change....... Done

@julianoes
Copy link
Contributor

Oh dear. Thanks @davids5 !

@davids5
Copy link
Member Author

davids5 commented May 25, 2024

Ok so once this compiled is did not boot. The Cause was that the last commit on Nuttx 0f401a6062653795b6355c420ea8b0e72578c204 cause the ITCM to be write protected, which caused fault on reboot.

The Fix is adding an additional mpu_configure_region(IMXRT_ITCM_BASE, 256 * 1024, before jumping to the APP.

But a bug in NuttX was preventing the MPU reset prior to reinitialization. - This has been fixed, unstreamed and backported.

@igalloway @PetervdPerk-NXP @vincentpoont2 : Bootloader replacement is needed! This PR provides a working bootloader and APP and should installed on all HW. Using PX4 after 470bea9 will fail to boot without the bootloader from this PR.

@davids5 davids5 marked this pull request as ready for review May 25, 2024 08:14
@igalloway
Copy link
Contributor

Thanks David, Peter.

@dk7xe we will need to offline plan for updating the bootloader in the existing validation units.

@davids5 davids5 force-pushed the pr-fix-px4_fmu-v6xrt-bootloader branch from c14f866 to 98267b9 Compare May 28, 2024 12:18
@MaEtUgR
Copy link
Member

MaEtUgR commented May 29, 2024

Thanks for the build and CI fix David! Is this still blocked or verified to solve the issues now? As far as I can see the remaining CI errors are not related. Let's work through and get them all fixed. We can coordinate in the dev call in a few minutes.

@davids5
Copy link
Member Author

davids5 commented May 29, 2024

Thanks for the build and CI fix David! Is this still blocked or verified to solve the issues now? As far as I can see the remaining CI errors are not related. Let's work through and get them all fixed. We can coordinate in the dev call in a few minutes.

@MaEtUgR It is ready to come in and get backported to the 1.15 backports

@dagar dagar merged commit f655d1b into main May 29, 2024
88 of 93 checks passed
@dagar dagar deleted the pr-fix-px4_fmu-v6xrt-bootloader branch May 29, 2024 15:08
@MaEtUgR MaEtUgR mentioned this pull request May 29, 2024
8 tasks
@MaEtUgR
Copy link
Member

MaEtUgR commented May 29, 2024

Thanks again 👍
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants