feat(notebooks): use normalized parameter names PS-13855 blocked on paperspace/PS_API#1764 #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszCki
reviewed
May 28, 2020
BartoszCki
suggested changes
May 28, 2020
| @attr.s | ||
| class Notebook(object): | ||
| id = attr.ib(type=str, default=None) | ||
| machine_type = attr.ib(type=str, default=None) |
| @attr.s | ||
| class NotebookStart(object): | ||
| notebook_id = attr.ib(type=str, default=None) | ||
| machine_type = attr.ib(type=str, default=None) |
Contributor
Author
There was a problem hiding this comment.
I would like to leave the old fields in the models because the responses have not been updated to the new field names yet.
| MODEL = models.Notebook | ||
|
|
||
| id = marshmallow.fields.Str() | ||
| machine_type = marshmallow.fields.Str(load_from="machineType", dump_to="machineType") |
| MODEL = models.NotebookStart | ||
|
|
||
| notebook_id = marshmallow.fields.Str(load_from="notebookId", dump_to="notebookId") | ||
| machine_type = marshmallow.fields.Str(load_from="machineType", dump_to="machineType") |
bbatha
force-pushed
the
feat-notebook-param-normalization
branch
from
dfda523 to
879aa6a
Compare
Contributor
Author
|
@BartoszCki this is ready for review |
BartoszCki
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.