feat(notebooks): support logs PS-13712 #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszCki
suggested changes
Jun 8, 2020
Contributor
Author
|
@BartoszCki ready for re-review |
BartoszCki
reviewed
Jun 8, 2020
| return table_string | ||
|
|
||
|
|
||
| class NotebookLogsCommand(LogsCommandMixin, BaseNotebookCommand): |
Contributor
There was a problem hiding this comment.
Again: Why is this class moved to the end of the file?
BartoszCki
suggested changes
Jun 8, 2020
Comment on lines
+210
to
+228
|
|
||
| def _make_table(self, logs, id): | ||
| table_title = "%s %s logs" % (self.ENTITY, id) | ||
| table_data = [("LINE", "MESSAGE")] | ||
| table = terminaltables.AsciiTable(table_data, title=table_title) | ||
|
|
||
| for log in logs: | ||
| table_data.append(self._format_row(log)) | ||
|
|
||
| return table.table | ||
|
|
||
| def _get_log_row_string(self, id, log): | ||
| log_msg = "{}\t{}".format(*self._format_row(log)) | ||
| return log_msg | ||
|
|
||
| @staticmethod | ||
| def _format_row(log_row): | ||
| return (style(fg="red", text=str(log_row.line)), | ||
| log_row.message) |
Contributor
There was a problem hiding this comment.
Why is this moved to the end of the class? You could have implemented those methods without moving them around.
Contributor
There was a problem hiding this comment.
Doing changes this way makes it harder to read git file history
BartoszCki
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.