-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change email summary setting copy to be clearer #9303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
force-pushed
the
chore/changeEmailSummarySettingCopy
branch
from
January 4, 2024 14:59
f715eb5
to
64b24b7
Compare
24 tasks
mattkrick
added a commit
that referenced
this pull request
Jan 18, 2024
* chore: Users with noTemplateLimit flag can use paid templates (#9160) * chore: Users with noTemplateLimit flag can use paid templates * Don't show a lock if a user can access premium templates regardless whether it's because their tier or a feature flag * feat: fix custom template border (#9131) * chore: Add SAML setup to new checkout flow (#9178) * chore: Add SAML setup to new checkout flow * Add Authorization also to mobile dash * chore(release): release v7.7.0 (#9161) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * feat: add GCS as a FileStore (#8493) * feat: add GCS as a FileStore Signed-off-by: Matt Krick <matt.krick@gmail.com> * self-review: fix comments Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: checkExists Signed-off-by: Matt Krick <matt.krick@gmail.com> * dockerize testing the branch * add recent filestore changes to gcs Signed-off-by: Matt Krick <matt.krick@gmail.com> * throw on trailing slash Signed-off-by: Matt Krick <matt.krick@gmail.com> * retry GCS flakey pushes Signed-off-by: Matt Krick <matt.krick@gmail.com> * dockerize Signed-off-by: Matt Krick <matt.krick@gmail.com> * bump yarn.lock Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix yarn Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Rafael Romero <rafael@parabol.co> * fix: replace saas url with calculated value for PPMIs (#9186) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: Users with noTemplateLimit flag can create custom templates (#9162) * chore: Users with noTemplateLimit flag can create custom templates * Allow creating templates on legacy dialog with noTemplateLimit flag * chore: Handle migration conflicts (#9166) * chore: test case: should not run for no migration Signed-off-by: Matt Krick <matt.krick@gmail.com> * test: working case Signed-off-by: Matt Krick <matt.krick@gmail.com> * test: failing case Signed-off-by: Matt Krick <matt.krick@gmail.com> * debug failing case * test basename Signed-off-by: Matt Krick <matt.krick@gmail.com> * test working case * better logs Signed-off-by: Matt Krick <matt.krick@gmail.com> * test no migration Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix(demo): Don't show top bar or sidebar on demo summary (#9190) * feat(admin): Base Org Admin role (#9194) * fix: Avoid caching permissions with different arguments (#8670) * fix: Avoid caching permissions with different arguments Permissions are cached by function name. When these depend on the arguments passed, they should have their own cache key, see https://the-guild.dev/graphql/shield/docs/rules#limitations * Make isViewerOnTeam strict The passed function might access source or args and thus we should use the strict cache. * fix: sort team names alphabetically (#9187) * fix: sort team names alphabetically * sort allTeamsOnOrg * chore(release): release v7.8.0 (#9185) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: can auto join with saml login (#9189) * chore(release): release v7.8.1 (#9224) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * feat: node update v20.9.0 LTS, req rethinkdb-ts and uWS version bump (#9232) * chore: Sorted .env.example and added more documentation (#9104) * Sorted .env.example and added more documentation * Added changes related to PR. Improved section naming. * Fixed CI variable location * Sorted variables and created new categories for GOOGLE, DATADOG, AWS. Added missing variables. * Requested changes incorporated --------- Co-authored-by: Rafael Romero <rafael@parabol.co> * feat: Free trial mutations (#9132) * feat(trials): Start Trial mutation * GQL + FE updates * Copy update * Minor fixes * End Trial mutation * Some cleanup * More fixes * Rename var * Extract 'getFeatureTier' * More cleanup * Tiny cleanup * CR: change to featureTier and billingTier * CR: Misc fixes * Rename featureTier back to just tier * CR: Explicitly do OrgUser and User updates in order * CR: Combine rethink queries * Actually we don't need to do those in a specific order * Why are tests broken * Revert "CR: Combine rethink queries" This reverts commit 04ad78d. * Revert "Why are tests broken" This reverts commit eca6417. * Manually bisecting changes that break tests (part 1) * Revert "Manually bisecting changes that break tests (part 1)" This reverts commit db90ead. * Revert "Revert "CR: Combine rethink queries"" This reverts commit a8c21a7. * Fix tests 🤦 * Update trial copy for OrgPlansAndBillingHeading * fix: release please build add systemtap (#9241) * fix: systemtap path (#9242) * feat: Add Microsoft login (#8984) * feat: Add Microsoft login * Microsoft login button styling * Add Microsoft login to forgot email and team invitation dialogs * Cleanup and pseudoId * Formatting * Use colors from the palette for oauth login buttons * Cleanup * chore(kudos): add kudos team settings (#9163) * chore(kudos): add kudos team settings * store emoji id * chore(kudos): add kudos record when adding emoji reaction (#9169) * chore(kudos): add kudos team settings * store emoji id * chore(kudos): add kudos record when adding emoji reaction * Fix snackbar * quick fix for types * Dynamic emoji * del console log * Remove comment * Remove unused kudos field * expose senderUser * Fix reactable type * Fix table name * Don't check feature flag * Fix analytics * Add snackbar events * fix typescript * feat(kudos): display notification when kudos received (#9199) * chore(kudos): add kudos team settings * store emoji id * chore(kudos): add kudos record when adding emoji reaction * Fix snackbar * quick fix for types * Dynamic emoji * del console log * feat(kudos): display notification when kudos received * Remove comment * Update notification text * Remove unused kudos field * expose senderUser * Fix reactable type * Fix table name * remove unused fields * Don't check feature flag * Fix analytics * Add snackbar events * fix typescript * Fix type * Fix type * add notification status analytics * Fix type * fix type * Fix table name caused by wrong merge * add snackbar clicked event to kudosReceived snackbar * chore: Fix formatting (#9244) * fix: author should be nullable when comment was anonymous (#9233) * fix: author should be nullable when comment was anonymous * fix: anonymous avatars path * chore(release): release v7.9.0 (#9238) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * chore(env-file): ununsed variables removed (#9249) * chore(metrics): add metrics to track search query in AL (#9235) * feat: remove gcal flag (#9251) * remove gcal feature flag * remove gcal feature flag * fix provider list * fix: increases integration icon visibility (#9164) * increases integration icon visibility * force commit * yank comment * feat: update activity library card UI (#9168) * show title and type below activity card * make activity library card dynamic * add retro background swirls * add background images for all meeting types * fix custom card size * truncate text if there is no space * clean up * use grape 100 * add premortem and postmortem imgs * remove bg from categories themes * move background img to div * chore: Cleanup Slack/Mattermost/MSTeams notifiers (#9240) * chore: Cleanup Slack/Mattermost/MSTeams notifiers These will need some refactoring for #8840 and this will hopefully simplify this. * Cleanup * feat: add tooltip to activity library card (#9236) * show title and type below activity card * make activity library card dynamic * add retro background swirls * add background images for all meeting types * fix custom card size * truncate text if there is no space * clean up * use grape 100 * add premortem and postmortem imgs * remove bg from categories themes * move background img to div * add dummy tooltip * fix tailwind bg colours * show tooltip after delay * show descriptions in tooltip * clean up * update tooltip position * update CATEGORY_THEMES colours * remove tailwind config safelist * feat: gcal invite all by default (#9260) * chore(dx): allow any branch with hotfix prefix to build (#9263) Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: cork all http write methods (#9261) * auto-cork, sse not working Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: auto-cork, sse not working Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(dx): allow any branch with hotfix prefix to build Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: double star glob to match / Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.10.0 (#9250) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * feat: release checkout flow (#9245) * remove checkout flow flag * remove checkout flow feature flag uses * update release tests * remove OrganizationPage * feat(admin): Org Admin permissions - billing leader and team lead permissions (#9195) * WIP feat(admin): First pass on Org Admin permissions - org perms * Org Admin - team lead perms * Check super-user when demoting org admin * Fix options in org member view * Handle bad orgId + userId inputs * CR: Simplify logic + add comments * Include love@ email address for contacting support * fix: shake some images from server bundle (#9267) Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: activity library settings mobile (#9275) * add minimize animation * fix cta on desktop and mobile * ensure cta buttons have a higher z index that the minimized content * add useMenu comment * fix: activity library colour imports (#9277) * fix: update activity library category colours * fix category themes background colours * chore: Check SERVER_ID in generateUID (#9270) * chore: Check SERVER_ID in generateUID If the server id is out of range, we potentially generate duplicate ids, so it's better to throw immediately. * Leave breadcrumps * chore: Reuse data loader for analytics (#9239) * chore: Reuse dataloader for analytics * Cleanup * Formatting * More cleanup * Cleanup * Confusion * fix: gracefully remove consumer from redis on sigterm (#9252) * gracefully remove consumer from redis on sigterm Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: gracefully remove consumer from redis on sigterm Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: rename services in datadog trace (#9048) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: webpack client and server in parallel (#9279) * chore: webpack client and server in parallel Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: cleanup my ugly code Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: Restrict prompt to join org to a smaller set of orgs (#9265) Prefer higher tiers and bigger over smaller orgs. * feat: added option to modify icebreakers with ai (#9268) * feat: added option to modify icebreakers with ai * code cleanup, analytics * code cleanup * fix: added success property to icebreaker modified analytics event * refactor: use relay mutation helper for modify check in question mutation * feat: add modified question char limit * chore: efficient webpack bundles (#9256) * fix: no opaque responses Signed-off-by: Matt Krick <matt.krick@gmail.com> * add min bundle size Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: only dynamic cache parabol assets Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * feat: Show new meeting snack also on summary page (#9231) * feat: Show new meeting snack also on summary page Because the meeting summary shows the sidebar as well, this feels more in line with the user expectation. * Fix demo * fix: Prompt to join org without organization feature flags (#9280) When no organization feature flag was present, we would not show the prompt to join org notification. * chore: Automatically add devops to changes in .env.example * chore: Update auto-request-reviewer workflow * fix: Update organization on accept invite (#9281) * fix: Prompt to join org without organization feature flags When no organization feature flag was present, we would not show the prompt to join org notification. * fix: Update organization on accept invite When accepting an invite in a different tab, or if the team lead accepts a prompt to join org invite, the new organization was added partially to the viewers organization causing undefined errors. * fix: grab auth token before await (#9292) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: keep release process in GitHub (#9165) * chore: release to staging from github Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: push to prod on PR merge Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: naming Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: hotfix branch name prefix Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: poll for pipeline in staging Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.11.0 (#9271) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: Fix duplicate organizations for teams with auto join (#9290) * fix: Fix duplicate organizations for teams with auto join If an organization had multiple teams with `autoJoin` enabled, multiple `OrganizationUser` objects would be created for a new user. This fixes the creation of duplicate `OrganizationUser` objects but does not fix the existing duplicates. Ideally we would add a migration for this, but filtering over all `OrganizationUser` entries is expensive and only the Parabol org is affected. * Add test * Fix adjustUserCount properly instead * fix: release-to-staging debug (#9294) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.11.1 (#9293) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: release-to-staging debugging 2 (#9295) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.11.2 (#9296) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * chore: disable autoJoin test (#9304) The test fails randomly, supposedly because the underlying issue is not completely fixed yet. This should be fixed in #9302, until then let's unblock CI. * chore: Change email summary setting copy to be clearer (#9303) * chore(deps): bump tj-actions/changed-files in /.github/workflows (#9299) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v40...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(meeting-inception): use retrosInDisguise flag for displaying add an activity button (#9297) * feat(kudos): send kudos by text in standups (#9259) * feat(kudos): send kudos by text in standups * Remove console logs * Fix test * Store unicode emoji too * Link teamPromptResponseId * Update slack notification * Update email notification * Mention notification analytics * response mentioned toast analytics * isValid * Add types * chore: document SOCKET_PORT environment (#9309) * fix: Fix kudosSent analytics (#9310) * fix: add pr write permission to CI (#9313) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.12.0 (#9305) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: release to staging debug #4 (#9315) * fix: add pr write permission to CI Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: release-staging handle async job creation Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.12.1 (#9316) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * chore: Convert GraphQL meeting types to use codegen (#9306) * chore: Convert GraphQL meeting types to use codegen * Cleanup * Cleanup * fix: longer timeout for unplayable job (#9321) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.12.2 (#9317) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: gh release staging debug (#9322) * fix: longer timeout for unplayable job Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: exit condition debug Signed-off-by: Matt Krick <matt.krick@gmail.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.12.3 (#9323) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: default to empty instead of null (#9325) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.12.4 (#9326) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * feat(kudos): enable mentions in retro reflections (#9284) * feat(kudos): send kudos by text in standups * Remove console logs * Fix test * Store unicode emoji too * Link teamPromptResponseId * Update slack notification * Update email notification * Mention notification analytics * response mentioned toast analytics * Enable mentions in retro reflections * feat(kudos): enable mentions in retro reflections * Make some params optional * make editorRef optional * Clear undo redo stack * chore: prepare start and endRetrospective for recurrence (#9318) Only refactored part of the functionality into different functions. * feat: Add custom category to activity library (#9319) * feat: Add custom category to activity library The custom category lists all team and organization custom templates. * Color adjustment * fix: Docker build readme updated with the correct PostgreSQL version (#9330) * chore: Update code review guidelines (#9307) * chore: Update code review guidelines * Update reviewers.yml * Renamed "One Review Required" to "Skip Maintainer Review" * Link to the label * Link to correct label * feat: remove unnecessary github oauth scopes (#8786) * feat(kudos): send kudos at the end of the retro (#9288) * feat(kudos): send kudos by text in standups * Remove console logs * Fix test * Store unicode emoji too * Link teamPromptResponseId * Update slack notification * Update email notification * Mention notification analytics * response mentioned toast analytics * Enable mentions in retro reflections * feat(kudos): enable mentions in retro reflections * feat(kudos): send kudos at the end of the retro * Handle anonymous notifications * Make some params optional * make editorRef optional * Clear undo redo stack * remove any * rebuild * make name and picture nullable * Change anonymous to someone * feat: adding integrations to team view tabs (#8985) * feat: adding integrations to team view tabs * fix/updating-integration-link * Remove TeamSettingsWrapper Only 1 route in it was still used, thus removed it * Fix links * Cleanup * Don't use emotion in new components --------- Co-authored-by: Georg Bremer <github@dschoordsch.de> * fix: Show correct template owner for ex-team members (#9331) Without this fix the edit controls were shown but did not work. * fix: highlight team dash in sidebar regardless of tab (#9333) * fix: highlight team dash in sidebar regardless of tab * Forgot Organizations on mobile * feat: ai template recommendation (#9223) * show title and type below activity card * make activity library card dynamic * add retro background swirls * add background images for all meeting types * fix custom card size * truncate text if there is no space * clean up * use grape 100 * add premortem and postmortem imgs * remove bg from categories themes * move background img to div * add search bar * add getTemplateSuggestion skeleton * show ai response to user * handle error states * remove ai search props * fix vertical scroll * fix padding * add padding on mobile * fix merge conflicts * add feature flag and add json response to open ai * make suggestedTemplate non null * clean up * remove activity grid from activityLibrary file * hide default search if showing ai search * remove unused imports * fix: Allow multiple "*New Template" (#9320) * fix: Allow multiple *NewTemplate * Add a number to new templates * Start counting from 1 * chore(configuration): .env with the minimal configuration to make the application work (#9335) * chore(configuration): all non required variables commented * PGAdmin section explained and SOCKET_PORT back and explained * fix: gh action release switch head to version tag (#9349) Signed-off-by: Matt Krick <matt.krick@gmail.com> * feat(kudos): show snackbar when reflection with kudos created (#9334) * feat(kudos): show snackbar when reflection with kudos created * Remove console log * snackbar key * chore: Add recurring retros feature flag (#9347) * chore: Add recurring retros feature flag * Make it an org flag * fix: fix broken demo summary (#9351) * chore: Distribute assignSURole (#9353) This is helpful in the docker image for initial setup. * feat: update activity library quick start (#9350) * add actvities to get you started title * show desired quick start templates in order * remove most popular * reduce margin * chore(release): release v7.13.0 (#9329) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: create release branch as head (#9356) Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: new branch debug (#9358) Signed-off-by: Matt Krick <matt.krick@gmail.com> * fix: release-to-staging create branch to act as a the PR head (#9359) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore: embedder add pgvector (and fixes) (#9341) * chore: add pgvector to development environment Postgres * fix: MailManagerDebug now always creates file paths under the O/S limit * fix: bump rethinkdb-ts (fixes development errors on my system) * chore: review fixes * chore(release): release v7.13.1 (#9357) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: contents: write for gh actions (#9361) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.13.2 (#9362) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> * fix: support edge cases in release to prod (#9364) Signed-off-by: Matt Krick <matt.krick@gmail.com> * chore(release): release v7.13.3 (#9365) Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Matt Krick <matt.krick@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Georg Bremer <github@dschoordsch.de> Co-authored-by: Nick O'Ferrall <nickoferrall@gmail.com> Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Krick <matt.krick@gmail.com> Co-authored-by: Rafael Romero <rafael@parabol.co> Co-authored-by: James Taber <jmtaber129@gmail.com> Co-authored-by: adaniels-parabol <71724289+adaniels-parabol@users.noreply.github.com> Co-authored-by: Marcus Wermuth <hello@marcuswermuth.com> Co-authored-by: Igor Lesnenko <igor.lesnenko@gmail.com> Co-authored-by: Bartosz Jarocki <jarocki.bartek@gmail.com> Co-authored-by: Rafa <101704572+rafaelromcar-parabol@users.noreply.github.com> Co-authored-by: Bruce Tian <tianrunhe@gmail.com> Co-authored-by: Terry Acker <ackernaut@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alicia Cressall <aliciacressall@gmail.com> Co-authored-by: Jordan Husney <jordan.husney@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes/Partially Fixes #[issue number]
[Please include a summary of the changes and the related issue]
Demo
[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]
Testing scenarios
[Please list all the testing scenarios a reviewer has to check before approving the PR]
Scenario A
Scenario B
Final checklist
One Review Required
if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'